GithubHelp home page GithubHelp logo

Comments (5)

ForbesLindesay avatar ForbesLindesay commented on April 28, 2024

Why not use devDependencies. These are only installed when you explicitly run npm install in the regenerator directory. This means they don't add bloat to production, but can be safely used in unit tests. At the moment you have a dependency in your tests that isn't specified in package.json

from regenerator.

benjamn avatar benjamn commented on April 28, 2024

Do you know if Travis CI runs npm install in the package directory? Speeding up tests was one of the main motivations here.

I'm inclined to wait to add it back until browserify is actually necessary for running tests.

from regenerator.

ForbesLindesay avatar ForbesLindesay commented on April 28, 2024

travis does, but you shouldn't be having a problem with travis build speed. I can't see how travis taking an extra 10 seconds or so can ever be a serious hindrance to development speed? You do however want to get rid of any dependencies that aren't needed at runtime so people don't have to install them when they just depend on regenerator.

mocha should never be an optionalDependency, since it's pretty much never needed at runtime.

from regenerator.

benjamn avatar benjamn commented on April 28, 2024

@ForbesLindesay wanna make a pull request to fix this up?

from regenerator.

ForbesLindesay avatar ForbesLindesay commented on April 28, 2024

done in #46

from regenerator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.