db_bench support user defined timestamp about rocksdb

[jowlyzhang]

We are blocked on this issue -- but don't think we have the capacity to take this ourselves as we aren't as familiar with this codebase/path

Thank you for this context. I will check this out soon by end of next week.

[dorlevi]

@jowlyzhang : thanks for assigning this to yourself. Do you know when you could pick this issue up?

[jowlyzhang]

@jowlyzhang : thanks for assigning this to yourself. Do you know when you could pick this issue up?

I don't think I will be able to check this soon, are you interested in taking it?

[dorlevi]

We are blocked on this issue -- but don't think we have the capacity to take this ourselves as we aren't as familiar with this codebase/path

[dorlevi]

hi, I wanted to check back in, thank you

[hilikspdb]

LDB scan and get do not work as well. The issue in LDB is that the caller must give timestamp for new iterator & Get (unlike snapshot where no snapshot means the latest). LDB can not create a timestamp without a knowledge on the cooperator. I think that in order to make ldb works the simplest way is to support null timestamp (get the latest version in get ; get all the versions in scan) in the read options.

[dorlevi]

@jowlyzhang -- wanted to check in again and see if this is planned to be addressed

[jowlyzhang]

I was actually recently working on this, the ./ldb get type of commands, like multiget, scan, get_entity etc should have read timestamp support after this PR #12641

I'm currently working on dump, wal_dump and idump for similar support and I will later work on the db_bench one.

[dorlevi]

Amazing ! Thank you so much we will stay tuned and test it out after

…

On Wed, May 22 2024 at 1:48 PM, Yu Zhang < ***@***.*** > wrote: I was actually recently working on this, the./ldb get type of commands, like multiget , scan , get_entity etc should have read timestamp support after this PR #12641 ( #12641 ) I'm currently working on dump , wal_dump and idump for similar support and I will later work on the db_bench one. — Reply to this email directly, view it on GitHub ( #12233 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AALD6HTSQ453VDKSG3IHIBLZDTLAPAVCNFSM6AAAAABBYYUYZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGQYTOMJWGE ). You are receiving this because you are subscribed to this thread. Message ID: <facebook/rocksdb/issues/12233/2125417161 @ github. com>