KeyError: 'port' about sapp

[abishekvashok]

What version of MT are you using @qlkwej ?

[qlkwej]

Should be the latest one mariana-trench 1.0.2 @abishekvashok
Another workaround I do is to provide a dummy sapp.db before the analysis.

And it's a bit weird, though sometimes it works, and sometimes it doesn't.

Use case 1:

• When I execute MT, and after that, analyze the output using sapp immediately (using bash), on the first try it will crash.
• But it works when I manually do it one by one (type in terminal).

Use case 2:

• When I execute MT, and after that, analyze the output using sapp immediately (using bash), on the first try it will crash.
• Wait a couple of minutes, and re-run the script. It works.

Use case 3:

• When I execute MT, and after that, analyze the output using sapp immediately (using bash), on the first try it will crash.
• After the crash, it creates a dummy sapp.db. So I used it before the sapp analysis. And now it works without crashing.

Feel free to close the issue if you can't reproduce the issue.
Thanks!

[0xedward]

Hey @qlkwej!

Should be the latest one mariana-trench 1.0.2

That's strange since my earlier guess at what may be happening is the json output from MT you are using for sapp analyze was created using a older version of MT, since we recently updated the MT output parser in sapp, which removed support for reading older versions of outputs from MT (see e484f216f7d95f8e33e1d1fa3586a18fa53552e3). As far as I'm aware, that should be only functional change from fb-sapp 0.5.2 to 0.5.3 related to the port key in MT's output

But the issue you are describing seems to only happen when sapp analyze is called the first time

cc @yuhshin-oss who likely has the most context on this

[dianavintila]

Hi! This is a problem that I had also when I tried to use Mariana Trench with version fb_sapp-0.5.4.dist-info.
The solution was to downgrade sapp:
pip uninstall fb-sapp
pip install -Iv fb-sapp==0.5.2

[a-huk]

Still the same issue, if I try the fix suggested by @dianavintila, I get :
ImportError: cannot import name 'GraphQLResolveInfo' from 'graphql' (/home/hukad/.venvs/mariana-trench/lib/python3.8/site-packages/graphql/__init__.py)