some response not showing in network tab about stetho

[b95505017]

I changed StethoInterceptor code these lines, then those responses appear into network tab successfully.

try {
    response = chain.proceed(request);
    if (response.body().contentType() == null) {
        response = response.newBuilder().header("Content-Type", "text/html").build();
    }
} catch (IOException e) {
    if (mEventReporter.isEnabled()) {
        mEventReporter.httpExchangeFailed(requestId, e.toString());
    }
    throw e;
}

[jasta]

Thanks that's really helpful. I'll fix this at a lower level so the fix works for stetho-urlconnection too.

[b95505017]

Thanks, looking forward to the next release!
Great library!

[longinoa]

Is the right course of action to assume text/html though? spec seems to indicate it should be application/octet-stream http://www.w3.org/Protocols/rfc2616/rfc2616-sec7.html

[jasta]

@longinoa It's not actually a Content-Type problem, it's DevTools' internal concept of ResourceType. We can convert a lack of Content-Type header to ResourceType.OTHER and it should work fine.

[jasta]

mimeType doesn't need to be faked but I do like using application/octet-stream anyway. Just in case the DevTools folks break stuff later :)

[b95505017]

Thanks! May I ask when could we get this on Maven?

[jasta]

@b95505017 working on getting a release (1.0.1) out the door this week.

[b95505017]

👍