Support for non-debuggable builds about stetho

[IgorGanapolsky]

@hzsweers ~"Stetho appears to only work if the build's debuggable flag is enabled". Not true at all. Have you looked at stetho-sample code? They do not have a debuggable flag.

[ZacSweers]

The stetho sample code doesn't configure any buildTypes. This implicitly results in using the default "debug" buildType, which in turn implicitly enables the debuggable flag.

If you create a new buildType (say, release) and built that instead without setting the debug flag (or setting it to false to be sure), it will not work.

[jasta]

Actually it does work fine in release builds its just that proguard obfuscation breaks our reflection based ChromeDevtoolsMethod and friends. If you -keepnames in your proguard config for all stetho classes, it will work. We've been looking at fixing this (explicitly mapping methods / parameters to strings) but it hasn't been a high priority yet.

[ZacSweers]

Are you sure that's it? We have this in our proguard, and it's not enough for us:

-keep class com.facebook.stetho.** { *; }

Unless just "keep" doesn't implicitly keep names?

[jasta]

@hzsweers I debugged this issue with another user on #80 who confirmed the fix you just proposed. I also know for sure that with obfuscation it will break. One thing you can do just to make sure proguard is working how you expect would be to run dexdump as discussed in #80 to confirm that indeed the important Stetho classes (like Network, Runtime, etc) are present and their names are unobfuscated.

[ZacSweers]

Huh, now that I try some more it seems to work fine. I'm wondering if maybe we still had the calls wrapped in an if (BuildConfig.DEBUG) call when we checked before...

Anyway, thanks for the help!