Layout on background thread? about textlayoutbuilder

[xiphirx]

To my knowledge yes, that code can be run on a background thread and be safe. All it does internally is create a Layout.

[vinc3m1]

See createTextLayout function in Litho, which is static and intended to run on any thread:
https://github.com/facebook/litho/blob/5dd4fcd5a8d1e06ad45e93e2af774c1f44d429a1/litho-widget/src/main/java/com/facebook/litho/widget/TextSpec.java#L550-L558

[AttwellBrian]

To my knowledge yes, that code can be run on a background thread and be safe. All it does internally is create a Layout.

Awesome. There isn't any concern about the thread safety of reading from the resource and context in the following line setTextAppearance(context, resId)?

See createTextLayout function in Litho, which is static and intended to run on any thread:
https://github.com/facebook/litho/blob/5dd4fcd5a8d1e06ad45e93e2af774c1f44d429a1/litho-widget/src/main/java/com/facebook/litho/widget/TextSpec.java#L550-L558

Thanks Vince! That is pretty compelling evidence. Though I'm still a little concerned about the resource reads.

[vinc3m1]

I was thinking that too, but I don't see a setTextAppearance function on TextLayoutBuilder, or any reference to Context at all actually.

[xiphirx]

The builder takes in already resolved values. We don't query Resources directly unless you use ResourceTextLayoutHelper, which will resolve values before passing them to the builder. The README seems to be wrong / outdated. I'll go ahead and fix that...