GithubHelp home page GithubHelp logo

Comments (3)

ianwal avatar ianwal commented on May 18, 2024 1

Yes, it looks like the dependencies for vpdq are not installed. They are listed in vpdq README.md.

For now, we can just add the dependencies where FFmpeg is installed in the workflow to fix vpdq test.


Other thoughts:

Is there a proper package manager that could be added for vpdq that is used at Meta, such as Conan? That would allow vpdq to manage its own build dependencies, preferably automatically installing them as needed (just for build stage). vpdq has no runtime dependencies.

Alternatively, we could just publish wheels for vpdq to avoid having to even build in most cases. I think cibuildwheels would work and be fairly simple to setup as an action.

from threatexchange.

Dcallies avatar Dcallies commented on May 18, 2024

Thanks a ton both @ianwal and @Jemeljanov for looking into this one.

I've merged #1569, and will do something shortly to confirm it fixed things.


In response to other thoughts:

Is there a proper package manager that could be added for vpdq that is used at Meta, such as Conan

This project is unfortunately limited by what tools I've used personally. So far, that has meant setup.py and pip, but even that is already outdated. I've had limited bandwidth so far this year to make improvements to our code due to competing priorities on my team at Meta, but making the repo more maintainable is a goal I'm tracking.

Alternatively, we could just publish wheels for vpdq to avoid having to even build in most cases. I think cibuildwheels would work and be fairly simple to setup as an action.

I'll also check this out as well, I'm going to open a new issue (#1571) for exploration of both of these.

from threatexchange.

Dcallies avatar Dcallies commented on May 18, 2024

Confirmed that #1569 Fixed py-tx build!

from threatexchange.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.