Comments (3)
Yes, it looks like the dependencies for vpdq are not installed. They are listed in vpdq README.md.
For now, we can just add the dependencies where FFmpeg is installed in the workflow to fix vpdq test.
Other thoughts:
Is there a proper package manager that could be added for vpdq that is used at Meta, such as Conan? That would allow vpdq to manage its own build dependencies, preferably automatically installing them as needed (just for build stage). vpdq has no runtime dependencies.
Alternatively, we could just publish wheels for vpdq to avoid having to even build in most cases. I think cibuildwheels would work and be fairly simple to setup as an action.
from threatexchange.
Thanks a ton both @ianwal and @Jemeljanov for looking into this one.
I've merged #1569, and will do something shortly to confirm it fixed things.
In response to other thoughts:
Is there a proper package manager that could be added for vpdq that is used at Meta, such as Conan
This project is unfortunately limited by what tools I've used personally. So far, that has meant setup.py and pip, but even that is already outdated. I've had limited bandwidth so far this year to make improvements to our code due to competing priorities on my team at Meta, but making the repo more maintainable is a goal I'm tracking.
Alternatively, we could just publish wheels for vpdq to avoid having to even build in most cases. I think cibuildwheels would work and be fairly simple to setup as an action.
I'll also check this out as well, I'm going to open a new issue (#1571) for exploration of both of these.
from threatexchange.
Confirmed that #1569 Fixed py-tx build!
from threatexchange.
Related Issues (20)
- [hma] Fetcher policy fails to access index HOT 1
- [hma] submitting content gets stuck between "hashed" and "matched" HOT 2
- /matches/for-hash/ gives AttributeError: 'IndexMatchUntyped' object has no attribute 'distance' HOT 1
- [pytx] No match results if creating a local_file with only 1 hash in it HOT 1
- [hma] Size of hashkey has exceeded the maximum size limit of 2048 bytes HOT 3
- [hma] ValueError in indexer
- [vpdq] Add support for Windows in vpdq pypy package HOT 5
- [OMM] Set up basic Continuous Integration git workflows for OMM HOT 2
- [omm] Figure out design for background tasks HOT 5
- [hma] Test production deployment - Nice-to-haves and Need-to-haves HOT 4
- [omm][onboarding] Initial setup issues HOT 2
- psycopg2.errors.UndefinedTable: relation "signal_type_override" does not exist HOT 8
- [vpdq] pypi publish failing HOT 2
- [omm][hma] Move Open Media Match into the Hasher Matcher Actioner Directory HOT 1
- Refactor UI to allow for multiple pages
- Flask background task scheduler doesn't run if werkzeug is not the WSGI server
- [vpdq] Explore other packaging and build options
- [hma] Add optional distance parameter in match API
- [pytx] Add support for StopNCII PhotoDNA
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from threatexchange.