Comments (6)
We haven't forgotten about this! I'm testing out a change now which would limit strict_text searches to the primary field (name, indicator, etc) for the type of data being searched.
from threatexchange.
That would be useful! If the change doesn't work, would it be breaking things too much to convert strict_text from a Boolean to a string which represents the field to apply strict searching on?
from threatexchange.
I'd like to keep strict_text as a boolean. We can change it's exact behavior, but what @mgoffin is proposing will be better in a different field. (text_field=description ?) A person may want to search another field with or without wildcards. (text="Jesse's best C2 server"&text_field=description&strict_text=1 vs. text="APT555"&field=description)
Regardless, the code to modify the behavior of strict_text has passed initial testing and is in the queue to be pushed next week. Using the example from above, I am now able to limit the data being returned s.t. that the text field must be in the indicator when strict_text is true.
I'm going to leave this open until the code is pushed and you can test it out. Let's revisit this next Wednesday and hopefully close this out.
from threatexchange.
@jessek I like your suggestion even better!
from threatexchange.
Is the new strict text working for you?
from threatexchange.
I'm going to close this issue out now, but please reopen it if you have any issues.
from threatexchange.
Related Issues (20)
- [py-tx] Typing of SignalExchangeAPIWithSimpleUpdates is too Generic | remove use of t.Any
- [py-tx] CLI error opaque for PDQ match with low hash quality HOT 1
- [py-tx] Use the new NON_MALICIOUS reaction
- pdq_hasher error for B/W png HOT 1
- [py-tx] SignalType Reference implementation for Video TMK+PDQF Matching
- [py-tx] ThreatExchange checkpoint time implementation is incorrect, potentially skipping updates HOT 2
- [py-tx] Investigate dbm as a replacement for the default store
- /matches/for-hash/ returns 400, could not parse request HOT 9
- [hma] Clicking Sync button on the webui doesn't do anything
- [py-tx] New extension interface for storage
- [py-ty] Venv setup documentation and/or files
- [hma] Cleanup Settings > ThreatExchange Tab
- [hma] 500 error thrown on invalid PDQ hash HOT 1
- [HMA] graph API 9.0 hardcoded, now deprecated HOT 1
- [py-tx][HMA-in-a-bottle] Modularising py-tx -- Draft roadmap HOT 6
- [hma] Fetcher policy fails to access index HOT 1
- [hma] submitting content gets stuck between "hashed" and "matched" HOT 2
- /matches/for-hash/ gives AttributeError: 'IndexMatchUntyped' object has no attribute 'distance' HOT 1
- [pytx] No match results if creating a local_file with only 1 hash in it HOT 1
- [hma] Size of hashkey has exceeded the maximum size limit of 2048 bytes HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from threatexchange.