Compilation problem in Ubuntu 14.04 with g++-4.9 about wangle

[tomsercu]

I have the same issue installing wangle on a RHEL6 system, using gcc 4.9. I have folly @ cef5789.
This occurs both when compiling with the default -std=c++0x (giving the error just like above),
and with -std=c++14 in CMakeLists.txt it will indicate it is trying to use make_unique from gcc-4.9.2_rhel6/include/c++/4.9.2/bits/unique_ptr.h, however the error remains the same.

[tomsercu]

No answer from JunhoSuh or the developers.
The error comes from the fact that old versions of folly had a non-standard make_unique that takes 2 template arguments. This is now removed, presumable so that make_unique follows the std::make_unique in c++14.
You can work around it like this (in acceptor/ConnectionManager.h)

  template<typename... Args>
  static UniquePtr makeUnique(Args&&... args) {
    //return folly::make_unique<ConnectionManager, Destructor>(
    //  std::forward<Args>(args)...);
    return std::unique_ptr<ConnectionManager, Destructor>(
      new ConnectionManager(std::forward<Args>(args)...));
  }

[fugalh]

This is due to repositories being out of sync (folly and wangle).

On Wed, Oct 21, 2015 at 3:48 PM Tom Sercu [email protected] wrote:

No answer from JunhoSuh or the developers.
The error comes from the fact that old versions of folly had a
non-standard make_unique that takes 2 template arguments. This is now
removed, presumable so that make_unique follows the std::make_unique in
c++14.
You can work around it like this (in acceptor/ConnectionManager.h)

template<typename... Args>
static UniquePtr makeUnique(Args&&... args) {
//return folly::make_unique<ConnectionManager, Destructor>(
// std::forward(args)...);
return std::unique_ptr<ConnectionManager, Destructor>(
new ConnectionManager(std::forward(args)...));
}

—
Reply to this email directly or view it on GitHub
#11 (comment).