Watchman crash on path = . about watchman

[wez]

Thanks for reporting this; I've pushed a fix.

FWIW, path='.' will never match anything in watchman; the root is referred to as the empty string internally, and the '.' and '..' nodes are never indexed or referenced.

The path generator is intended to be used in cases where you have a large tree with a large volume of changes and want to phrase your query as "walk all the files in path: return all that were modified since X", rather than "for each changed file since X, return all that match a path".

The generators specify the file walking strategy; the expression term is used to match results and add them to the result set.

If you want to check for changes since a prior query, you are generally better off using the since generator; move the since term out of the expression and place it alongside the expression. Then make your expression use a name matching term instead.

If you just want to match any files that changed, you only need to include the since generator in your query.

[dturner-tw]

Wow, thanks for the fast and comprehensive response!

[wez]

Thanks for including a backtrace; made it super quick to resolve :)