Handle relative paths correctly about watchman

[wez]

The path is resolved by the watchman server which has a working dir set to /, and you're right in that you don't really want to be watching everything.

Handling relative paths in all cases means replicating the server logic in the client, and then it wouldn't behave in quite the same way as clients that are using the JSON or BSER protocols.

I'm leaning towards a simpler sanity check: if the path doesn't start with a / when it reaches the server, we can return an error and ask you pass in the absolute path.

In the meantime, I'd recommend using watchman watch $PWD instead

[wez]

(we can also disallow watching / while we're in there)

[wez]

wez@wez-mbp master ~/fb/watchman-pure
9:54 $ ./watchman watch .
{
    "version": "2.9.6",
    "error": "unable to resolve root .: path \".\" must be absolute"
}
wez@wez-mbp master ~/fb/watchman-pure
9:54 $ ./watchman watch $PWD
{
    "version": "2.9.6",
    "watch": "/Users/wez/fb/watchman-pure"
}

I'm calling this "good enough" for now. I have some hacking lined up for the CLI that might address making it smarter, we'll see how far I get.

[schickling]

👍 for relative paths

[rhacker]

this is not merged ?

[wez]

b8832cc is in the tree, and I get this when I run what's in master:

$ ./watchman watch .
{
    "version": "2.9.8",
    "watch": "/Users/wez/fb/watchman"
}

so this is done. Are you trying something and it isn't working?

[rhacker]

thanks, I have an old version. Everything works fine for now :)