GithubHelp home page GithubHelp logo

NetBSD supports statvfs about watchman HOT 4 CLOSED

0-wiz-0 avatar 0-wiz-0 commented on May 2, 2024
NetBSD supports statvfs

from watchman.

Comments (4)

wez avatar wez commented on May 2, 2024

Thanks!

I've verified that this doesn't break the Solaris code path, and the man page you referenced makes this seem like f_fstypename is the correct field name.

Would you like to submit this as a pull request so that we can take it in and associate it with you in the repo history?

from watchman.

0-wiz-0 avatar 0-wiz-0 commented on May 2, 2024

Thanks for the very quick feedback!
I've created
#51
for this.

from watchman.

0-wiz-0 avatar 0-wiz-0 commented on May 2, 2024

Ok, Travis reports this patch doesn't work on OS X.
fstype.c:63:29: error: no member named 'f_basetype' in 'struct statvfs'
return w_string_new(sfs.f_basetype);

We could either move the statfs block above the statvfs, or add an explicit check for OS X and do not enter the statvfs case then. What do you prefer, or do you have another suggestion? What symbol properly checks for OS X?

from watchman.

wez avatar wez commented on May 2, 2024

Thanks! Let's move the discussion to #51; I'll close this one in favor of that one

from watchman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.