Comments (7)
It is present in the legacy
folder
The provided Makefile
is supposed to automatically include this directory.
from zstd.
Ah, my mistake - I was updating ZStd in lzbench, which doesn't have the folder.
How about defaulting ZSTD_LEGACY_SUPPORT to 0, so that the legacy folder is only required if specifically desired?
from zstd.
It's a matter of preference.
I'm not sure whichever option is better "by default".
So I opted for the "safer" one, so that people / projects having used Zstd prior version don't get accidentally blocked.
from zstd.
Sure, understood. I was assuming from the major version being zero, that api changes were assumed to be okay at any time. That is minor issue with semantic versioning before the first major release.
Thank you.
from zstd.
Actually, thinking again about it, something I could do and feels logical :
- when built using the default provided
Makefile
: setZSTD_LEGACY_SUPPORT
to 1 - when file is just being copy pasted into another project and no
ZSTD_LEGACY_SUPPORT
value is provided, set it to 0
This way, when including zstd into another project, the expectation, in general, is to not need additional legacy files.
from zstd.
That looks to be a very good solution to me. It is difficult to balance having the code out there for people to use and report bugs etc, before committing to a major version. Keeping the main lib folder as current and self sufficient would make adoption easy, while minimizing the penalty for early adoptors to migrate to changes.
from zstd.
pushed into dev branch
from zstd.
Related Issues (20)
- Modernize macros to use `do { } while (0)` instead of `{ }` HOT 9
- [question] Seek for insights on the suitable case for zstd dictionary compression HOT 5
- zstd not buildable with PAC/BTI becauseof `huf_decompress_amd64.S` HOT 4
- get a core dump on use ZSTD_compressCCtx (Unhandled exception access violation) HOT 3
- Adding a library to https://facebook.github.io/zstd/#other-languages HOT 1
- Allow files bigger than 2GiB for --patch-from option HOT 1
- Allow files bigger than 2GiB for --patch-from option HOT 2
- [Question] How to force single literal streams during compression HOT 1
- Export "selected" CMake target for zstd HOT 5
- [Question] Understanding of compression level with external sequence producer HOT 2
- zstd fails to process some filenames on Windows [we need a hero] HOT 3
- We need a ZStd JavaScript library HOT 1
- Compiler warnings present when integrated with Swift Package Manager
- will zstd get nvcomp acceleration or a gpu support like g-brotli? HOT 1
- How can I change the window size? HOT 1
- Increase minimum C standard from C89/C90 to C11 HOT 3
- New zstd 1.5.5 version is two times slower in compression speed than older 1.4.5 version HOT 11
- ZSTD with T option does not scale on multicore CPUs HOT 7
- Question about FSE Huffman literal part
- C++ Builder and mem.h ambiguity HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zstd.