GithubHelp home page GithubHelp logo

Comments (3)

klauspost avatar klauspost commented on September 21, 2024

Ah... It could be extra block data failing this check... Closing until I've clarified.

No. This doesn't appear to be it.

from zstd.

klauspost avatar klauspost commented on September 21, 2024

This appears to be something that has changed, with a MIN_CBLOCK_SIZE. Latest version appear to decode this.

Closing, since it appears these blocks now decode.

from zstd.

Cyan4973 avatar Cyan4973 commented on September 21, 2024

Indeed,
this is a known limitation of older decoder versions.

It's documented here :
https://github.com/facebook/zstd/blob/dev/doc/decompressor_errata.md#compressed-block-with-0-literals-and-0-sequences

It has been fixed since.

Even though newer versions of zstd decode such blocks, it's recommended to avoid generating such block, in order to improve compatibility with the installed base of zstd decoders. Besides, as you noticed, it's just a wasteful way to represent "empty", so it's good practice for the encoder to select a more compact representation.

from zstd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.