Comments (5)
Someone asked me about AMD offline so might as well post here. On genoa (Zen4) AVX512 is actually ~30% faster ( 1135871 ns/op vs 885935 ns/op).
from zstd.
Regression on Intel is bigger than gain on AMD, so disabled by default makes sense. Using the same XXH_ENABLE_AUTOVECTORIZE
to allow opt-in is probably the best.
from zstd.
We already disable vectorization for xxhash32 if sse4 is present, so we should probably do the same for xxhash64 and avx512.
Indeed,
this seems like the same issue,
and we should probably use a similar solution.
from zstd.
OK, so it makes the situation a bit less clear,
since avx512
is now sometimes beneficial, sometimes detrimental.
It probably opens the door towards offering a user choice on this topic.
However, it doesn't remove the question of "what's a good default",
and if I read the situation correctly, it seems that disabling avx512
for xxh64
remains a reasonable default at this point in time.
from zstd.
from zstd.
Related Issues (20)
- seekable_format/examples/parallel_compression.c is not parallel
- use decompress
- soft link
- [More convenient build options] Cmake or meson/ninja? HOT 1
- --exclude-compressed in environement variable HOT 6
- Windows binaries are missing on v1.5.6 release HOT 3
- Clicking the website URL on GitHub repository displays a warning if browser is in HTTPS-only mode
- MSVC CMake build failed on v1.5.6
- v1.5.6 Windows binary downloads are double zipped HOT 4
- Raise version's in win32 binaries header HOT 3
- Why was the new release 1.5.6 removed? HOT 15
- long file names are cut off in output HOT 3
- Should zstd check archive consistency before overwriting files? HOT 1
- Should zstd delete incomplete archives? HOT 5
- 32-bit x86 build failure with 1.5.6 HOT 3
- v1.5.6 breaks 32-bit Windows clang-cl build HOT 3
- Decompress multiple zstaa backups on FAT32 drives HOT 4
- Replication of bug #3517 HOT 16
- Separate dictionary references to enable dictionary usage for any combination of window size and content size HOT 1
- Decompression speed regression in zstd 1.5.6 (win)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zstd.