GithubHelp home page GithubHelp logo

Comments (5)

TocarIP avatar TocarIP commented on April 28, 2024 1

Someone asked me about AMD offline so might as well post here. On genoa (Zen4) AVX512 is actually ~30% faster ( 1135871 ns/op vs 885935 ns/op).

from zstd.

TocarIP avatar TocarIP commented on April 28, 2024 1

Regression on Intel is bigger than gain on AMD, so disabled by default makes sense. Using the same XXH_ENABLE_AUTOVECTORIZE to allow opt-in is probably the best.

from zstd.

Cyan4973 avatar Cyan4973 commented on April 28, 2024

We already disable vectorization for xxhash32 if sse4 is present, so we should probably do the same for xxhash64 and avx512.

Indeed,
this seems like the same issue,
and we should probably use a similar solution.

from zstd.

Cyan4973 avatar Cyan4973 commented on April 28, 2024

OK, so it makes the situation a bit less clear,
since avx512 is now sometimes beneficial, sometimes detrimental.
It probably opens the door towards offering a user choice on this topic.

However, it doesn't remove the question of "what's a good default",
and if I read the situation correctly, it seems that disabling avx512 for xxh64 remains a reasonable default at this point in time.

from zstd.

Cyan4973 avatar Cyan4973 commented on April 28, 2024

Cyan4973/xxHash#924

from zstd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.