GithubHelp home page GithubHelp logo

exit nonzero upon write failure about zstd HOT 3 CLOSED

facebook avatar facebook commented on April 25, 2024
exit nonzero upon write failure

from zstd.

Comments (3)

Cyan4973 avatar Cyan4973 commented on April 25, 2024

Self note : programs/zstd already detects such situation when input is not stdin, that is :

$ programs/zstd somefilename > /dev/full; echo $?
Error 25 : Write error : cannot write compressed block
25

from zstd.

Cyan4973 avatar Cyan4973 commented on April 25, 2024

Jim Meyering :
You just got lucky/unlucky.
The code detects fwrite failure, but not the failure of the write induced by fclose, so if you start with a smaller input or if the error strikes only for the final write, that other usage fails to detect the error, too:
$ echo foo > k && programs/zstd k > x; echo $?
Compressed 4 bytes into 14 bytes ==> 350.00%
0

from zstd.

Cyan4973 avatar Cyan4973 commented on April 25, 2024

Fixed into 5b14760
Also : this test has been added to the automated test suite

from zstd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.