Comments (8)
Note once you play with the theme toggle, your choice becomes persisted in localstorage and we don't use the system color anymore: it is only used for the initial visit, so make sure to use an incognito session or clear localstorage before testing.
We also have a respectPrefersColorScheme
option to use system color in priority.
from infima.
(oh didn't notice we are on the Infima repo, but anyway this is a Docusaurus-related topic, not really Infima, because Infima only adapt its CSS according to a HTML class name that the Infima user (ie Docusauurs) has to set.
from infima.
but wonder why do you care that much? 😅
Maybe cuz Hacktoberfest. Feel free to make a PR!
from infima.
(oh didn't notice we are on the Infima repo, but anyway this is a Docusaurus-related topic, not really Infima, because Infima only adapt its CSS according to a HTML class name that the Infima user (ie Docusauurs) has to set.
Cool, Docusauurs doesn't seem to have any such issue, my bad, thanks for pointing out.
I was just looking for beginner friendly stuff to contribute :)
from infima.
Note once you play with the theme toggle, your choice becomes persisted in localstorage and we don't use the system color anymore: it is only used for the initial visit, so make sure to use an incognito session or clear localstorage before testing.
We also have a
respectPrefersColorScheme
option to use system color in priority.
Heyya, looks like the docusaurus.config.js of the infima website doesn't have the property respectPrefersColorScheme
set to true.
Upon trying locally the website seems to open with light/dark theme depending upon the system theme only when this property is set to true like you mentioned
Is this intentional or would you welcome an update making that true? 😄
from infima.
Hey
You can add that respectPrefersColorScheme: true
config if you want, but wonder why do you care that much? 😅
from infima.
Hey
You can add that
respectPrefersColorScheme: true
config if you want, but wonder why do you care that much? 😅
Nothing much, I was just looking at the docs, and I tend to get most websites in dark mode since I set my system to dark mode. I understand it is not a big deal to have it by default, as there is the switch, but I just tend to notice things like this since light mode burns my eyes 😅. Never mind 😇
from infima.
but wonder why do you care that much? 😅
Maybe cuz Hacktoberfest. Feel free to make a PR!
Okay 😄
from infima.
Related Issues (20)
- Use of `background` property to set background color clobbers other background properties HOT 4
- Better dark mode color palette HOT 6
- Doc sidebar active category not highlighted HOT 1
- Stepper component HOT 9
- SCSS rewrite proposal HOT 4
- Images with height attribute set do not preserve aspect ratio HOT 6
- Logo not loading in 'Multi-Column' example for footer HOT 11
- Visual testing
- using docusaurus - problem with css from using it HOT 1
- Footer logo styling artifically restricts real uses HOT 5
- Dark mode Badge text color contrast is bad HOT 3
- Render better long sidebar category labels?
- Code sample for "active" Button include "outline" classes HOT 1
- Variables with zero-value should include unit HOT 1
- navbar shouldn't contain the navbar mobile sidebar
- TOC should be allowed to display with @media print
- Search icon doesn't change color between light/dark mode HOT 2
- [deleted]
- [deleted]
- Document color usage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from infima.