GithubHelp home page GithubHelp logo

Comments (2)

Async10 avatar Async10 commented on June 15, 2024

I'm not a maintainer here nor a designer but pretty much everything you crititque seems fine to me. You can't work with shadows in dark mode that is why they use different color variations for contrast to achieve the separation of different areas or elements. Why would the text color on a badge change in dark mode need to change? The background color of the badge stays the same, so the text color has to for contrast and readability.

from infima.

armano2 avatar armano2 commented on June 15, 2024

Why would the text color on a badge change in dark mode need to change?

to make it consistent with other elements, eg, buttons adjust font color when in dark mode

from infima.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.