GithubHelp home page GithubHelp logo

Comments (3)

cbalioglu avatar cbalioglu commented on August 29, 2024 1

Hey @ezyang, nice to see you here :) It has been a while. Sorry, we have been very busy lately, just catching up with some of the pending PRs. I checked #152 as well and looks like the ordering of the header file directories in compile commands causes the issue (we use a different version of fmt in fairseq2n). Just changed the reordering of CMake dependencies. Do you mind checking whether that works

from fairseq2.

ezyang avatar ezyang commented on August 29, 2024

Here is a better workaround:

diff --git a/fairseq2n/src/fairseq2n/data/immutable_string.h b/fairseq2n/src/fairseq2n/data/immutable_string.h
index 86ba7bf..2e9817b 100644
--- a/fairseq2n/src/fairseq2n/data/immutable_string.h
+++ b/fairseq2n/src/fairseq2n/data/immutable_string.h
@@ -211,6 +211,10 @@ public:
    ~invalid_utf8_error() override;
 };
 
+inline auto format_as(const immutable_string& s) {
+  return s.to_string();
+}
+
 }  // namespace fairseq2n
 
 template <>
diff --git a/fairseq2n/src/fairseq2n/fmt.h b/fairseq2n/src/fairseq2n/fmt.h
index 44bc000..50e047e 100644
--- a/fairseq2n/src/fairseq2n/fmt.h
+++ b/fairseq2n/src/fairseq2n/fmt.h
@@ -20,6 +20,7 @@ struct repr {};  // disabled (i.e. poisoned)
 #include <string>
 #include <type_traits>
 
+#define FMT_HEADER_ONLY
 #include <fmt/core.h>
 #include <fmt/format.h>
 

from fairseq2.

cbalioglu avatar cbalioglu commented on August 29, 2024

Closing for now. Feel free to reopen it if the issue persists.

from fairseq2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.