GithubHelp home page GithubHelp logo

Comments (7)

ebsmothers avatar ebsmothers commented on July 21, 2024 2

@theadamsabra if not, you are more than welcome to take it up

from multimodal.

theadamsabra avatar theadamsabra commented on July 21, 2024 2

@ebsmothers thanks! If I don't get a response by tomorrow I'll just pick it up myself

from multimodal.

youssefadr avatar youssefadr commented on July 21, 2024 1

Thanks for your answer @ebsmothers, I would like to add the model to torchmultimodal/models first.

from multimodal.

ebsmothers avatar ebsmothers commented on July 21, 2024 1

That sounds reasonable to me. We already have CLIP visual encoders in the library here, so feel free to reuse those. Then the bulk of the work for the model should be to add the LLM. A couple pointers to help with that: TransformerDecoderLayer, RMSNorm. We also have an open PR for rotary positional embeddings (#450) that might be useful. Let me know if this makes sense, happy to provide more details as needed.

from multimodal.

youssefadr avatar youssefadr commented on July 21, 2024 1

Nice ! I'll come back to you with more questions later, not sure I'll start working on it this week.

from multimodal.

ebsmothers avatar ebsmothers commented on July 21, 2024

Hi @youssefadr, thanks for opening this issue. LLaVA is definitely something we're interested in adding and we would be happy to have you contribute. Is there a specific portion of the model you're especially interested in helping out with?

from multimodal.

theadamsabra avatar theadamsabra commented on July 21, 2024

@youssefadr have you worked on this to any capacity? i'm interested in picking this up if not

from multimodal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.