GithubHelp home page GithubHelp logo

Comments (6)

georges-berenger avatar georges-berenger commented on August 11, 2024 1

Put your custom image filter code in a class derived from the RecordFilterCopier class, that you pass to vrs::utils::filterCopy via a custom MakeStreamFilterFunction that injects the right filter for each stream (or calls makeCopier for the streams that shouldn't be modified).

from vrs.

georges-berenger avatar georges-berenger commented on August 11, 2024

Have you tried class RecordFilterCopier in https://github.com/facebookresearch/vrs/blob/main/vrs/utils/FilterCopyHelpers.h ? It should allow you to do what you need.

from vrs.

chenjoya avatar chenjoya commented on August 11, 2024

Thank you so much. I have solved my problems. In fact I am working with Meta's Ego4D team and we need this to blur face in VRS file. I provide my implementation here: https://github.com/chenjoya/vrsfacem/blob/master/vrs/vrs/utils/cli/MakeFaceMosaicCopier.cpp
Do you have some guidances?

from vrs.

georges-berenger avatar georges-berenger commented on August 11, 2024

good to hear you're unblocked.
The code looks good.
Suggestion:
shouldCopyVerbatim() is a lot more complicated than need be:
makeFaceMosaicCopier could use RecordFileReader::mightContainImages and RecordFileReader::mightContainAudio to either return a FaceMosaic if mightContainImages is true, otherwise a makeZeroFilterCopier if mightContainAudio is true, otherwise, a Copier. Then you can delete most of the code in shouldCopyVerbatim and filterAudio entirely.

from vrs.

chenjoya avatar chenjoya commented on August 11, 2024

Nice. VRS is really talented. I learned a lot.

Thank you so much!

from vrs.

georges-berenger avatar georges-berenger commented on August 11, 2024

You're welcome!

from vrs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.