GithubHelp home page GithubHelp logo

Comments (13)

henryruhs avatar henryruhs commented on May 22, 2024 3

Like I know the Gradio hash... anyway, I gonna fix that asap. Thanks for the report.

from facefusion.

henryruhs avatar henryruhs commented on May 22, 2024

Could you help me understanding the issue by providing some screenshots? I doubt it is loaded 2 times.

from facefusion.

felixsanz avatar felixsanz commented on May 22, 2024

Sure. I deleted /tmp/gradio to make sure nothing exists.

1693412793

Then I drag and drop the video into the target zone.

1693412744

And if you check /tmp/gradio now...

1693412797

2 folders with different hash but the same video. Since this is mounted to RAM it's always consuming double RAM than needed.

I know I can move the temp folder to a disk but in RAM is fast and nice, it's just that it shouldn't be here duplicated.

from facefusion.

henryruhs avatar henryruhs commented on May 22, 2024

This is indeed an issue cause by the my integration.

To have just one drop area for images and videos I use gradio.File instead of gradio.Image and gradio.Video next to each other. According to the media type I display gradio.File instead of gradio.Image.

I didn't expect they load that file twice to the RAM.

from facefusion.

felixsanz avatar felixsanz commented on May 22, 2024

It happens with every asset. The face image you upload to the "source" zone, it happens too (if that helps)

from facefusion.

henryruhs avatar henryruhs commented on May 22, 2024

The source.py is made the same way like the target.py - not because it is needed but to have the same UI concept.

from facefusion.

henryruhs avatar henryruhs commented on May 22, 2024

grafik

Could be solved either with Tabs or by unloaded the File components once the media type is known.

from facefusion.

felixsanz avatar felixsanz commented on May 22, 2024

Unloading the old "file" instance and keeping the "video" or "image" one seems to be a better solution to me, so the UI doesn't get more complex without needing

from facefusion.

henryruhs avatar henryruhs commented on May 22, 2024

I agree... but that needs lot of refactoring

from facefusion.

felixsanz avatar felixsanz commented on May 22, 2024

I agree... but that needs lot of refactoring

why? just when the file is uploaded... there is already 2 times, remove the old one with os.remove()

from facefusion.

henryruhs avatar henryruhs commented on May 22, 2024

The good news: source_file and target_file are no longer used across the application. I use source_image, target_image and target_video now.

The bad news: unloading the file components does not result in the wanted behavior.

This might stay unfixed for 1.1.0 in case nobody sends a pull request until tomorrow.

from facefusion.

henryruhs avatar henryruhs commented on May 22, 2024

I created a issue: gradio-app/gradio#5809

Please vote it up!

from facefusion.

henryruhs avatar henryruhs commented on May 22, 2024

I resolved this as wontfix... closed on the Gradio side - the decision is made that we move away from this framework.

from facefusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.