[PATCH] File#open with write flag does not clear existing files. about fakefs

[qrush]

+1 to this.

[jmhodges]

The functionality is absolutely needed. I'm not too terribly inclined with this patch.

Checking the mode and clearing the file out if it exists belongs in File#initialize.

You can see this behavior with the normal File class:
irb(main):001:0> Dir['']
=> ["lib", "LICENSE", "pkg", "Rakefile", "README.markdown", "subdir", "test", "tmp"]
irb(main):002:0> File.new('foo', 'w')
=> #File:foo
irb(main):003:0> Dir['']
=> ["foo", "lib", "LICENSE", "pkg", "Rakefile", "README.markdown", "subdir", "test", "tmp"]

[jmhodges]

Obviously, what is also not captured in your tests is that the file should be created if it does not exist but the directory above it does.

[jmhodges]

That last bit is also not captured, iirc. Expected behavior:

irb(main):002:0> File.new('bar/foo', 'w')
Errno::ENOENT: No such file or directory - bar/foo
  from (irb):2:in `initialize'
  from (irb):2:in `new'
  from (irb):2
  from :0

[Narnach]

Looks like I'll have to add more tests to check the edge cases.
Clearing the file in File#initialize does make more sense.
I'll look into it today and see if I can improve it on my topic branch.

[jmhodges]

Cool. I've got some tests here that are failing that I'll push up.

[Narnach]

Great. I'll keep an eye out for them. Thanks!

[jmhodges]

Hm, okay, so these are an okay start.

A bunch of tests will fail if you actually implemented the code for test_File_new_errors_if_directory_above_it_does_not_exist because many tests rely on being able to write directly to /path/to without creating it first.

I'd hack this out more, but I broke some stuff w.r.t. File.open with my current implementation and it is way, way too late for hacking. (I think the initial values of FileSystem.dir_levels and FileSystem.fs need to change but that's just a gut feeling and I've thought that and been wrong before.)

[jmhodges]

(Oh, and if those values do have to change, pay attention to line 94 in fileutils.rb. Ugh, I hate that I wrote that.)

[Narnach]

Thanks for the warning that tests will fail due to the /path/to thing. IRB confirms you get an error, so fakefs should act the same. There's fixing to be done :)

[Narnach]

Because File.expand_path is not yet faked, there are 9 tests that break because file path expansion (for directory existence checking) does not operate within the faked FS but still relies on the current working directory outside of FakeFS.

The upside is that the tests you gisted now pass :)

I've pushed the changes (with those 9 failing tests) to my topic branch.

Faking File.expand_path will likely require mucking around in the FileSystem internals as you predicted :)

[smtlaissezfaire]

Files modes are respected properly in this branch:

http://github.com/smtlaissezfaire/fakefs/tree/file_modes

[Narnach]

Those changes look good!

[defunkt]

Merged, thanks Scott!