Comments (4)
Should I provide a PR with only the sidebar change?
Yes please.
When writing code, I can imagIne the feeling just from text. But for stuff like websites, I like demos/PRs for these because they allow me to experience the change.
If the main menu change isnt conflicting with the other change, you can create a PR for that as well. Thanks for the clarification.
from faker.
I don't understand your main menu suggestion.
As for the sidebar suggestion 1, I like it, I would like to try the actual look and feel though.
Does vitepress support that natively?
from faker.
I don't understand your main menu suggestion.
Does this make it more clear?
Before | After |
---|---|
As for the sidebar suggestion 1, I like it, I would like to try the actual look and feel though.
Does vitepress support that natively?
Yes. The screenshots in the issue where done by changing the vitepress config locally. Should I provide a PR with only the sidebar change?
from faker.
I'm neutral on the main menu changes
Solution 1 for sidebar seems like a definite improvement so I'd do that.
Also I feel the "API Reference" should show the sidebar. Currently it is hidden there.
from faker.
Related Issues (20)
- Speed up normalisation code HOT 8
- Release Checklist v9.0.0-alpha.0 HOT 1
- create icon on simple-icons HOT 32
- Localization lastName is not working HOT 2
- Phone numbers should support special numbers HOT 1
- Check capitisation of ex_MX/color/human
- Add v9.fakerjs.dev
- Generate Planet names HOT 9
- More varied product descriptions HOT 2
- Can't use Faker with k6 HOT 16
- Vehicle data is very US-centric HOT 1
- Improve specification of lorem module and definitions HOT 5
- Add plugin support for modules HOT 2
- Check whether complex objects should be frozen HOT 3
- Reevaluate word distribution
- Create Intl based tests for date definitions HOT 3
- Check whether the locale data should use locale aware sorting HOT 3
- 'lorem.words' missing for zh_CN HOT 5
- Use singular locale definition keys HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faker.