Comments (8)
Nice, going to install a 3.0 in lab and try it out.
Thanks for the report!
--
Regards Falk
from pyise-ers.
Hi, when finally installing a 3.0 in homelab.. puh what a beast :)
This started with 2.7 I think. I tried that one too.
So the "plan" is to make "device_group" optional in the function.
Don't really know how I will make it backwards compatible. But perhaps the easier way is to default on < 2.7 (or what version that change was in) and then do a config option for what ISE is the host..
--
Regards Falk
from pyise-ers.
If you change the function definitions like this:
def add_device(self,
name,
ip_address,
radius_key,
snmp_ro,
dev_group=None,
dev_location=None,
dev_type=None,
description='',
snmp_v='TWO_C',
dev_profile='Cisco',
tacacs_shared_secret=None,
tacas_connect_mode_options='ON_LEGACY'
):
This should still allow existing code to work. Then you just need to add a relevant code block in the function to test and split old vs new functionality... "if dev_group". Since you can't have a =None in the middle, you'll probably have to add some sanity checking to make sure dev_location and dev_type are values that they need to be.
Maybe something like this?
if not dev_group:
# code specific to ise 3.0
pass
elif not dev_location or not dev_type:
# error if these are actually required parameters
pass
else:
# original code here
pass
I don't use this part of ISE right now, but I do have ISE 2.4, 2.6, 2.7 and 3.0 in my lab. Happy to help with any kind of regression testing if you have some thoughts on how you want to fix this (I'll probably need some detail on what I need to configure in ISE to actually test this).
from pyise-ers.
Ouch, I really messed up with that merge @jasonbarbee..
@joshand I would really be glad with some help with regression testing and thoughts :)
I have now pushed a new 2.7 and 3.0 on my poor kvm server @ home :)
And #152 made dev_group optional with dev_group=None.
But the PR that @jasonbarbee made that checks versioning is really interesting too.
--
Regards Falk
from pyise-ers.
@mortiz-code - Can you test out the master branch and see it things works as expected?
--
Regards Falk
from pyise-ers.
@falkowich thanks for the fix. Any chance to update the PyPi soon?
from pyise-ers.
I will check this out as soon as #164 is done
--
Regards Falk
from pyise-ers.
This will be included in PyPi release pyise-ers 0.2.0
from pyise-ers.
Related Issues (20)
- Library doesn't use timeout in all requests library function calls HOT 6
- Defork and namechange to get compliance against Cisco DevNet policies. HOT 11
- add get_endpoint_byname HOT 5
- Help with maintenance of this repo.
- Get codecov over 70% HOT 1
- On ISE 3.0 a faulty connection doesn't return "response": Unauthorized HOT 2
- Bulk support HOT 2
- replace pipenv with poetry HOT 2
- Update packets from pypi. HOT 1
- Do test for 2.7
- Do test for 3.0
- Do test for 3.1
- Do test for 3.2 HOT 1
- Release 0.3 to PyPI.
- Update documentation for 0.3.x HOT 1
- Change to f-strings in output HOT 1
- looking for some suggestion to implement some ISE commands HOT 2
- Dynamic pagination for _get_groups and _get_objects HOT 2
- Add filter to get_device_groups HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyise-ers.