Opening "Search structurally" opens CODEOWNERS scope filtering dialog about intellij-codeowners

[fan-tom]

The issue is that com.github.fantom.codeowners.search.CodeownersSearchScopeDescriptor#getScope is called from com.intellij.structuralsearch.plugin.ui.ScopePanel#SCOPE_FILTER, to filter out some scopes. It doesn't affect Class Hierarchy scope the same way it affects mine, because this scope is filtered out by name:

  private static final Condition<ScopeDescriptor> SCOPE_FILTER =
    (ScopeDescriptor descriptor) -> IdeBundle.message("scope.class.hierarchy").equals(descriptor.getDisplayName()) ||
                                    !(descriptor.getScope() instanceof ModuleWithDependenciesScope); // don't show module scope

It is not triggered when using "Find in Files" because it uses a different flow, where similar filter doesn't invoke getScope:

// com.intellij.find.impl.FindPopupScopeUIImpl#initComponents

    myScopeCombo.init(myProject, true, true, selection, new Condition<>() {
      //final String projectFilesScopeName = PsiBundle.message("psi.search.scope.project");
      final String moduleFilesScopeName;

      {
        String moduleScopeName = IndexingBundle.message("search.scope.module", "");
        final int ind = moduleScopeName.indexOf(' ');
        moduleFilesScopeName = moduleScopeName.substring(0, ind + 1);
      }

      @Override
      public boolean value(ScopeDescriptor descriptor) {
        final String display = descriptor.getDisplayName();
        return /*!projectFilesScopeName.equals(display) &&*/ !display.startsWith(moduleFilesScopeName);
      }
    });

As we can see, ModuleWithDependenciesScope is filtered out using just name, without scope instantiation.

There are other extension points other than com.intellij.scopeDescriptorProvider to implement scopes: com.intellij.searchScopesProvider and com.intellij.customScopesProvider, but neither of them is designed for scopes, that require showing custom UI to define the scope, and the only builtin scope with such UI is carefully handled in the code (hardcoded)