coc-rust-analyzer doesn't display "related information" diagnostics ("value moved here" etc) about coc-rust-analyzer

[fannheyward]

diagnostic.separateRelatedInformationAsDiagnostics has added into coc.nvim.

[fannheyward]

Agreed, showing related informations will do grep help for user. We should not be limited to how VSCode does.

[fannheyward]

coc.nvim + coc-rust-analyzer already support relatedInformation diagnostic, but not displayed in floating window. Put your cursor on line 6 x, current diagnostic position, run :CocCommand workspace.diagnosticRelated, you will get related informations in coc lists.

I'll try to improve this.

[fannheyward]

Try :CocUpdate. I've displayed relatedInformation messages with diagnostic message. You still need :CocCommand workspace.diagnosticRelated to do jumping.

[Ferdi265]

Thank for the quick answer/fix! Much more usable now :)

However, I usually use the virtual text feature much more than the floating messages, so seeing them there would be the absolute best, but I think I'll try experimenting with the plugin code myself and report my findings when I did :)

[Ferdi265]

With a bit of experimentation I managed to create separate diagnostics from the related information.

IMO this should probably be solved directly in neoclide/coc.nvim though, since many language servers publish related information, which might be useful to see in-editor.

diff --git a/src/client.ts b/src/client.ts
index 4f749af..fdc6862 100644
--- a/src/client.ts
+++ b/src/client.ts
@@ -40,18 +40,26 @@ export function createClient(config: Config, bin: string): LanguageClient {
         return help;
       },
       handleDiagnostics: async (uri, diagnostics, next) => {
+        const mkInfoDiag = (related, diag) => {
+          return {
+            "code": diag.code,
+            "source": diag.source,
+            "message": related.message,
+            "range": related.location.range,
+            "uri": related.location.uri,
+            "severity": 4
+          };
+        };
+        const infos = [];
+
         diagnostics.map((diagnostic) => {
           if (diagnostic.relatedInformation) {
-            let message = `${diagnostic.message}\n\nRelated diagnostics: (Run \`:CocCommand workspace.diagnosticRelated\` to jump)\n`;
             for (const info of diagnostic.relatedInformation) {
-              const basename = path.basename(Uri.parse(info.location.uri).fsPath);
-              const ln = info.location.range.start.line;
-              message = `${message}\n${basename}(line ${ln + 1}): ${info.message}`;
+              infos.push(mkInfoDiag(info, diagnostic));
             }
-            diagnostic.message = message;
           }
         });
-        next(uri, diagnostics);
+        next(uri, diagnostics.concat(infos));
       },
     },
     outputChannel,

[fannheyward]

I was going to concat related information as diagnostics to all diagnostics list, same as what your patch does, but this is how VSCode + rust-analyzer does:

I don't know whether it's correct to separate the related informations to diagnostics list.

[Ferdi265]

At least for me, fixing bugs in a larger function is much easier when the related diagnostics are also shown directly in the editor.

It would be cool to have it as an option, so users can choose whether or not they should be shown as separate diagnostics.

Also, integrating the related information into the popup should IMO also be solved in coc.nvim, since it might be useful to have the message structured (this would allow switching between both styles for any language via a config option).

TL;DR:

• yes, if your whole goal is to just replicate the VS-code plugin, then your patch is better than mine
• fixing this for all of CoC would make this much more configurable and more flexible, on top of giving the user more choice in how to view his errors / warnings

I'm going to try to look at the CoC codebase, and see if I can integrate something like what you did, and as a configurable option my proposal.