Comments (2)
Hi @KushajveerSingh I am not confident this is a good idea for the following reasons:
- The message will be mostly the same, pointing to the docs on using git hooks and various nbdev cli functions
- The goal of the PR comment is to say "hey something is out of sync, please take a look at the CI logs". The last thing I want is for people to blindly apply CLI commands without first looking at the logs. Also the nbdev logs are quite helpful and are designed to help the user.
- I don't want to try to get into the business of propagating all of the logs onto a PR comment, as that is hard to do properly. I would like to lean on the error messages provided natively by nbdev.
- Many times, failure to install git hooks will result in both of these items failing simultaneously. I would hate for the person to be pinged n times for each separate type failure. Rather, I would prefer to gently alert them that there is an issue and have them inspect the logs for the failing tests. It is usually not common to implement PR comments for failing tests, however given the novelty of nbdev we wanted to provide a reminder to look at the contributing docs where it was obvious that a common mistake is being made.
I hope that background helps. I will leave this issue open for further discussion incase there are other opinions.
from fastai2.
That makes perfect sense. Thanks, for looking into this.
from fastai2.
Related Issues (20)
- AttributeError: type object 'Tensor' has no attribute 'as_subclass' HOT 2
- RuntimeError: imag is not implemented for tensors with non-complex dtypes. HOT 4
- Multi GPU Training for a unet_learner HOT 1
- nbdev_test_nbs do not work without a GPU HOT 2
- Can't nbdev_build_lib, File not found error HOT 7
- failed nbdev_build_lib, FileNotFoundError topnav.yml HOT 1
- Re-added `lang` to default tokenizer? HOT 1
- One must numericalize labels in FastAI2 metrics, unlike SKLearn metrics HOT 2
- README Needs to be refreshed HOT 1
- Not able to clone fastai-docs in my clone repo. HOT 5
- Learning rate finder breaks with pytorch DataLoader
- latest fastai2 v0.0.24 learner summary() RuntimeError: Input type (torch.cuda.FloatTensor) != weight type (torch.FloatTensor) HOT 1
- Have the ability to add our own type_tfms on test_dl HOT 3
- Cannot override tokenizer with TextBlock (tok_func does not exist as an argument anymore) HOT 1
- We might be able to "not" also fork `fastai-docs` HOT 1
- Does gradient clip in `to_fp16` really take effect ? HOT 1
- Don't turn layernorm into fp16 HOT 2
- Validation set contains unseen category as target HOT 1
- Major Bug regarding TensorPoints HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastai2.