`ascii_number.h` is closing `namespace` incorrectly about fast_float

[jwakely]

The plugin is just confused by this code:

fast_float/include/fast_float/ascii_number.h

Lines 283 to 287 in ff7cb44

	#ifdef FASTFLOAT_ALLOWS_LEADING_PLUS // disabled by default
	if ((*p == UC('-')) || (!(fmt & FASTFLOAT_JSONFMT) && *p == UC('+'))) {
	#else
	if (*p == UC('-')) { // C++17 20.19.3.(7.1) explicitly forbids '+' sign here
	#endif

There are two opening braces there, but only one needs to be closed. If your editor doesn't understand the C++ preprocessor groups, it will think they both need to be closed.

[Ahmad-S792]

Just to add when I add missing (I am using VSCode builtin function to highlight closing functions, so it might be 'VSCode' issue), I get following error:

      extraneous closing brace ('}')
} // namespace fast_float
^

[lemire]

I am going to close this. If you think that there is an unclosed namespace, I invite you to issue a pull request or to provide an analysis. As things stand, I only have a claim that there is faulty unclosed bracket... I need more evidence that there is a problem.

Note that this library is in widespread use.

[Ahmad-S792]

The plugin is just confused by this code:

fast_float/include/fast_float/ascii_number.h

Lines 283 to 287 in ff7cb44

	#ifdef FASTFLOAT_ALLOWS_LEADING_PLUS // disabled by default
	if ((*p == UC('-')) || (!(fmt & FASTFLOAT_JSONFMT) && *p == UC('+'))) {
	#else
	if (*p == UC('-')) { // C++17 20.19.3.(7.1) explicitly forbids '+' sign here
	#endif

There are two opening braces there, but only one needs to be closed. If your editor doesn't understand the C++ preprocessor groups, it will think they both need to be closed.

Most likely this is the case, I do have C++ extensions. Will try to find culprit. :-)