GithubHelp home page GithubHelp logo

Comments (12)

love-lena avatar love-lena commented on May 28, 2024 1

Well we can see from the logs that it is express-route-prefix. But even when running just one test by itself, I get numbers in the 10s. I think there are two different errors going on, but I am continuing to investigate.

from benchmarks.

RafaelGSS avatar RafaelGSS commented on May 28, 2024 1

Now it looks fixed in the repository. The website needs to be updated again. @luisorbaiceta could you help us with it?

from benchmarks.

luisorbaiceta avatar luisorbaiceta commented on May 28, 2024 1

Done!

from benchmarks.

love-lena avatar love-lena commented on May 28, 2024

If this is a "good first issue" I could have a crack at it. I've just picked up fastify recently so no promises. Anything I need to know about this package?

from benchmarks.

Eomm avatar Eomm commented on May 28, 2024

The pipeline shows a lot of errors: https://github.com/fastify/benchmarks/runs/5476672680?check_suite_focus=true

We should understand what has changed in the GH pipelines that have triggered this error. Maybe the default node.js version has been updated?

from benchmarks.

love-lena avatar love-lena commented on May 28, 2024

It actually looks like there were huge amounts of errors even before the numbers tanked.
Like 160,000 lines of

(node:2441) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
(node:2441) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit

Are these known/okay?

from benchmarks.

Eomm avatar Eomm commented on May 28, 2024

Are these known/okay?

I don't think so 😞

cc @fastify/benchmarks

from benchmarks.

RafaelGSS avatar RafaelGSS commented on May 28, 2024

@love-lena I would run each of those benchmarks individually until finding the one who's showing those warnings

from benchmarks.

luisorbaiceta avatar luisorbaiceta commented on May 28, 2024

Now it looks fixed in the repository. The website needs to be updated again. @luisorbaiceta could you help us with it?

Sure! Would a redeploy be enough?

from benchmarks.

RafaelGSS avatar RafaelGSS commented on May 28, 2024

I think so

from benchmarks.

luisorbaiceta avatar luisorbaiceta commented on May 28, 2024

Yep

https://deploy-preview-318--fastify-website.netlify.app/

from benchmarks.

RafaelGSS avatar RafaelGSS commented on May 28, 2024

It's fixed. Thank you!

from benchmarks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.