Comments (12)
Well we can see from the logs that it is express-route-prefix
. But even when running just one test by itself, I get numbers in the 10s. I think there are two different errors going on, but I am continuing to investigate.
from benchmarks.
Now it looks fixed in the repository. The website needs to be updated again. @luisorbaiceta could you help us with it?
from benchmarks.
Done!
from benchmarks.
If this is a "good first issue" I could have a crack at it. I've just picked up fastify recently so no promises. Anything I need to know about this package?
from benchmarks.
The pipeline shows a lot of errors: https://github.com/fastify/benchmarks/runs/5476672680?check_suite_focus=true
We should understand what has changed in the GH pipelines that have triggered this error. Maybe the default node.js version has been updated?
from benchmarks.
It actually looks like there were huge amounts of errors even before the numbers tanked.
Like 160,000 lines of
(node:2441) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
(node:2441) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
Are these known/okay?
from benchmarks.
Are these known/okay?
I don't think so 😞
cc @fastify/benchmarks
from benchmarks.
@love-lena I would run each of those benchmarks individually until finding the one who's showing those warnings
from benchmarks.
Now it looks fixed in the repository. The website needs to be updated again. @luisorbaiceta could you help us with it?
Sure! Would a redeploy be enough?
from benchmarks.
I think so
from benchmarks.
Yep
https://deploy-preview-318--fastify-website.netlify.app/
from benchmarks.
It's fixed. Thank you!
from benchmarks.
Related Issues (20)
- Failing cron job HOT 1
- Get script error when running benchmark compare HOT 1
- please add units to the table HOT 1
- Chalk v5 requiers ESM
- Add support to ESM HOT 4
- Add benchmarks for native NodeJS (LTS) server? HOT 7
- feat: add benchmark for istanbuljs HOT 7
- feat: change package name istanbuljs to galatajs
- Add Express 5 (Beta) benchmark HOT 1
- inquirer update broke everything HOT 2
- Add support to hyper-express HOT 3
- Update external Fastify benchmarks HOT 4
- Clean benchmarks list HOT 5
- Add tinyhttp benchmark
- Consistent Benchmark Result HOT 3
- Sveltekit Performance Benchmark Comparison HOT 4
- @tinyhttp/app Missing from dependencies causes benchmark to fail
- Fails to run HOT 1
- New release? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from benchmarks.