GithubHelp home page GithubHelp logo

Comments (8)

baremaximum avatar baremaximum commented on May 22, 2024

I had the same issue. This would be helpful.

from csrf-protection.

Tarang11 avatar Tarang11 commented on May 22, 2024

@jurca, can you have a look at this.

from csrf-protection.

jurca avatar jurca commented on May 22, 2024

@Tarang11 I confirm that the TypeScript definitions are out of date. While I was aware of this issue, I did not have time to fix them back then unfortunately :-( , but I do now.

I see two options: either update the TypeScript definitions (less work), or port the project to TypeScript (better maintainability). I'm willing to do the work and submit a PR.

Which option would you prefer?

from csrf-protection.

Tarang11 avatar Tarang11 commented on May 22, 2024

@jurca, just update the Typescript definitions. This keeps it simple for us and for the users as well.

from csrf-protection.

jurca avatar jurca commented on May 22, 2024

@Tarang11 Very well, but I think credit should go where credit is due, if you agree.

@mksony Would you submit a PR for this, please?

@Tarang11 I'll do the PR review :).

from csrf-protection.

Tarang11 avatar Tarang11 commented on May 22, 2024

ok

from csrf-protection.

mksony avatar mksony commented on May 22, 2024

@jurca I submitted a PR #17 and also included a test for the typings. Let me know what you think 🙂

from csrf-protection.

jurca avatar jurca commented on May 22, 2024

@Tarang11 Would you please publish a new version to npm?

from csrf-protection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.