Comments (10)
Yes, I prefer things to fail for modules. Otherwise you may not see that your module is broken when installed, due to an updated dependency.
(this is more philosophical in fact, this module has no dependencies - kind of the reason why I didn’t say anything in the beginning)
from fluent-json-schema.
.nvmrc
too I think
from fluent-json-schema.
@cemremengu Should I then ignore as well those file too?
- yarn.lock
- .editorconfig
- .gitignore
- .npmignore
- .nvmrc
- .prettierrc
- .travis.yml
from fluent-json-schema.
The listings in .gitignore
file should be enough (npm will also use it so no need for an .npmignore
file) just add .nvmrc
and .yarn.lock
to it. Also you should delete the files from the repo as well
from fluent-json-schema.
🤔I see, I guess I misunderstood your suggestion. Let me clarify
.nvmrc
is useful to keep in the repo in order to enforce the default node version if someone is working on it.
yarn.lock
is required in the repo for dev dependencies
So, to me, the best way it's adding both of them in the .npmignore
. TBH Not sure it worth to avoid this two files being published
from fluent-json-schema.
I think .nvmrc
and .lock
files are more suitable for applications rather than libraries. When making the suggestion my motivation was actually to have a similar structure as other plugins in the organization for consistency however the decision is yours to make :)
from fluent-json-schema.
@mcollina I saw you have approved my PR but after the chat with @cemremengu I'm not sure it's anymore aligned. Maybe you have a different perspective on this one
from fluent-json-schema.
Either it's fine. It depends on what you prefer to do. We gitignore yarn.lock
and package-lock.json
in all of the other repos of this orgs. Mainly because it complicates maintenance over time, and it prevent certain problems for being exposes. lock files are great for apps, not so much for modules and libraries.
from fluent-json-schema.
Does it mean you prefer to fail if your dependencies has been changed? So that you can fix the issue.
Howver, here we have zero dependencies apart the dev dependencies. To me it's nice to keep jest, jsdoc-markdown locked but defenitely not strong opinion here. I understand consistency so no problem to move both of them to .gitignore
if you prefer so.
from fluent-json-schema.
fixed by 8ea582f
from fluent-json-schema.
Related Issues (20)
- .id and .required not returning schema object HOT 1
- .raw({ nullable: true }) being inserted in the wrong position HOT 6
- Root level `required` creates invalid schema HOT 8
- Support "dependentrequired" and "dependentSchemas" HOT 5
- Support JSON Schema 2019-09 deprecated value HOT 4
- npm package does not match github repo HOT 3
- additionalProperties schemas causing unexpected behavior when passed to oneOf HOT 3
- How we can omit fields from request body that is not defined in the schema.
- .string() method validate all type values HOT 2
- 100 % code coverage HOT 1
- Set $id after clone HOT 7
- Conditional property is not allowed when using additionalProperties(false) HOT 3
- Unable to import in TS project with "moduleResolution": "NodeNext", HOT 12
- validate GET array of array param HOT 2
- Crashes on import HOT 2
- Nullable false not working HOT 1
- Object schema does not carry properties added by .raw() to a $ref HOT 3
- Object type ignored when nested properties use oneOf and raw HOT 11
- ReferenceError: Cannot access 'User' before initialization HOT 1
- Migrate test suite from `jest` to `node:test` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluent-json-schema.