Comments (4)
After digging into the closed issue. I can see that this behavior is made on purpose.
Related Issue #69 and #75
However, I think it should allow the required
api after the extend
.
The main reason is that I think most of the people need the required attributes after extend multiple schema.
from fluent-json-schema.
const Extend = S.object()
.prop('bar', S.string())
.required(['foo', 'bar'])
.extend(Base)
You can't require before the extend
.
{
"$schema":"http://json-schema.org/draft-07/schema#",
"type":"object",
"properties":{
"foo":{
"type":"string"
},
"bar":{
"type":"string"
}
},
"required":[
"foo",
"bar"
]
}
from fluent-json-schema.
It just inconvenient for the user to remember all work need to be done before extend
.
Another thing is the typescript typing is wrong for extend
. Therefore, I think require
can be done after extend
.
In conclude, some more work need to be done for the extend
API.
- typing should be fixed ASAP.
- better documentation for
extend
API
from fluent-json-schema.
from fluent-json-schema.
Related Issues (20)
- .id and .required not returning schema object HOT 1
- .raw({ nullable: true }) being inserted in the wrong position HOT 6
- Root level `required` creates invalid schema HOT 8
- Support "dependentrequired" and "dependentSchemas" HOT 5
- Support JSON Schema 2019-09 deprecated value HOT 4
- npm package does not match github repo HOT 3
- additionalProperties schemas causing unexpected behavior when passed to oneOf HOT 3
- How we can omit fields from request body that is not defined in the schema.
- .string() method validate all type values HOT 2
- 100 % code coverage HOT 1
- Set $id after clone HOT 7
- Conditional property is not allowed when using additionalProperties(false) HOT 3
- Unable to import in TS project with "moduleResolution": "NodeNext", HOT 12
- validate GET array of array param HOT 2
- Crashes on import HOT 2
- Nullable false not working HOT 1
- Object schema does not carry properties added by .raw() to a $ref HOT 3
- Object type ignored when nested properties use oneOf and raw HOT 11
- ReferenceError: Cannot access 'User' before initialization HOT 1
- Migrate test suite from `jest` to `node:test` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluent-json-schema.