GithubHelp home page GithubHelp logo

Comments (4)

lacostej avatar lacostej commented on April 27, 2024

Hello, this indeed looks like either a problem in fastlane, or something in the Apple ecosystem we do not support.

Could you run the command again with VERBOSE=true bundle exec fastlane precheck to see what extra output we get?

it would be useful to pinpoint if this fails for all IAPs or just some in particular. The verbose mode could help us find out which IAP it fails with. You can also then check your appstoreconnect setup to see if you see something special for that IAP.

from fastlane.

thejeff77 avatar thejeff77 commented on April 27, 2024

@lacostej thanks for the response.

Running bundle exec fastlane precheck --verbose gives me pretty much the same output. See below.

Additional feedback regarding this issue:

  • Precheckfile template does not include a way to skip in app purchase verification.
  • Error handling doesn't seem to be working very well - unexpected errors shouldn't block the release.
  • The string You can disable IAP checking by setting the include_in_app_purchases flag to false is very unhelpful, this should be a link to some documentation telling how to pass this string. For instance, in the lanes, its called something different: precheck_include_in_app_purchases: false, ++ nothing in the Precheckfile for this. A note to use --include_in_app_purchases=false would be helpful in the command itself, but often precheck isn't run on its own, its part of a deliver action.

Thanks again let me know if there is anything else I can provide to help.

developer@developer-MacBook-Pro  ~/Projects/myApp   master ●  bundle exec fastlane precheck --verbose                                                                   ✔  728  12:52:28 
[✔] 🚀 
Successfully loaded Appfile at path '/Users/developer/Projects/someProject/fastlane/Appfile'
- app_identifier: 'com.MFE.SomeApp'
- apple_id: '[email protected]'
- itc_team_id: '111114'
- team_id: 'someTeam'
-------
INFO [2024-02-17 12:53:01.42]: Successfully loaded '/Users/developer/Projects/someApp/fastlane/Precheckfile' 📄

+------------------------------------------------+
| Detected Values from './fastlane/Precheckfile' |
+--------------------------+---------------------+
| negative_apple_sentiment | {:level=>:error}    |
| curse_words              | {:level=>:error}    |
| future_functionality     | {:level=>:error}    |
| other_platforms          | {:level=>:error}    |
| placeholder_text         | {:level=>:error}    |
| test_words               | {:level=>:error}    |
| unreachable_urls         | {:level=>:error}    |
+--------------------------+---------------------+


+------------------------------------------------------------+
|                Summary for precheck 2.219.0                |
+--------------------------------+---------------------------+
| app_identifier                 | com.MFE.SomeApp |
| username                       | [email protected]  |
| team_id                        | 111111                 |
| platform                       | ios                       |
| default_rule_level             | error                     |
| include_in_app_purchases       | true                      |
| use_live                       | false                     |
| negative_apple_sentiment.level | error                     |
| placeholder_text.level         | error                     |
| other_platforms.level          | error                     |
| future_functionality.level     | error                     |
| test_words.level               | error                     |
| curse_words.level              | error                     |
| unreachable_urls.level         | error                     |
+--------------------------------+---------------------------+

INFO [2024-02-17 12:53:01.43]: Starting login with user '[email protected]'
Reading keychain entry, because either user or password were empty
Loading session from '/Users/developer/.fastlane/spaceship/[email protected]/cookie'
Looking for App Store Connect Team with ID 11111
INFO [2024-02-17 12:53:02.81]: Successfully logged in
INFO [2024-02-17 12:53:02.81]: Checking app for precheck rule violations
INFO [2024-02-17 12:53:05.91]: Reading in-app purchases. If you have a lot, this might take a while
INFO [2024-02-17 12:53:05.91]: You can disable IAP checking by setting the `include_in_app_purchases` flag to `false`

Looking for related GitHub issues on fastlane/fastlane...
Search query: {"data"=>nil, "messages"=>{"warn"=>nil, "error"=>["Not Found"], "info"=>nil}, "statusCode"=>"ERROR"}

URL: https://api.github.com/search/issues?q=%7B%22data%22%3D%3Enil%2C%20%22messages%22%3D%3E%7B%22warn%22%3D%3Enil%2C%20%22error%22%3D%3E%5B%22Not%20Found%22%5D%2C%20%22info%22%3D%3Enil%7D%2C%20%22statusCode%22%3D%3E%22ERROR%22%7D+repo:fastlane/fastlane
➡️  Fastlane Precheck Failure - Unexpected Response
   https://github.com/fastlane/fastlane/issues/21866 [open] 1 💬
   13 hours ago

➡️  create InAppPurchase product failure
   https://github.com/fastlane/fastlane/issues/20933 [open] 3 💬
   24 Jun 2023

➡️  [spaceship] Creation of in-app purchases returns NotFound error
   https://github.com/fastlane/fastlane/issues/19140 [closed] 11 💬
   13 hours ago

and 23 more at: https://github.com/fastlane/fastlane/search?q=%7B%22data%22%3D%3Enil%2C%20%22messages%22%3D%3E%7B%22warn%22%3D%3Enil%2C%20%22error%22%3D%3E%5B%22Not%20Found%22%5D%2C%20%22info%22%3D%3Enil%7D%2C%20%22statusCode%22%3D%3E%22ERROR%22%7D&type=Issues&utf8=✓

🔗  You can ⌘ + double-click on links to open them directly in your browser.
bundler: failed to load command: fastlane (/usr/local/bin/fastlane)
Spaceship::UnexpectedResponse: [!] {"data"=>nil, "messages"=>{"warn"=>nil, "error"=>["Not Found"], "info"=>nil}, "statusCode"=>"ERROR"}
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/spaceship/lib/spaceship/client.rb:793:in `parse_response'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/spaceship/lib/spaceship/tunes/tunes_client.rb:1320:in `load_iap'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/spaceship/lib/spaceship/tunes/iap_list.rb:59:in `edit'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/rule_processor.rb:166:in `block in generate_app_items_to_check'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/rule_processor.rb:165:in `each'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/rule_processor.rb:165:in `generate_app_items_to_check'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/rule_processor.rb:47:in `process_app_and_version'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/runner.rb:126:in `check_for_rule_violations'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/runner.rb:58:in `run'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/commands_generator.rb:42:in `block (2 levels) in run'
 /Library/Ruby/Gems/2.6.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
 /Library/Ruby/Gems/2.6.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
 /Library/Ruby/Gems/2.6.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:124:in `run!'
 /Library/Ruby/Gems/2.6.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/commands_generator.rb:72:in `run'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/precheck/lib/precheck/commands_generator.rb:20:in `start'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/cli_tools_distributor.rb:115:in `take_off'
 /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/bin/fastlane:23:in `<top (required)>'
 /usr/local/bin/fastlane:23:in `load'
 /usr/local/bin/fastlane:23:in `<top (required)>'

from fastlane.

lacostej avatar lacostej commented on April 27, 2024

Running bundle exec fastlane precheck --verbose gives me pretty much the same output. See below.

bundle exec fastlane precheck --verbose isn't the same as VERBOSE=true bundle exec fastlane precheck

The VERBOSE=true changes the way spaceship logs.

I am interested in seeing where in the interaction with AppStoreConnect spaceship fails. Hopefully the spacehip logs will give us more information.

I agree that some improvements can be done on the documentation and consistency of the information displayed.

from fastlane.

thejeff77 avatar thejeff77 commented on April 27, 2024

I've emailed this output to you. It is very long with emails and team ids and such in it, so I didn't post it here. Thanks 👍

from fastlane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.