GithubHelp home page GithubHelp logo

Comments (4)

mrnetops avatar mrnetops commented on May 23, 2024

Huh. I used @peterbourgon s release.fish script for the binaries.

Looking closer, it doesn't look like the release.fish produced binaries are intended to be statically linked as there is not a reference to CGO_ENABLED=0 in the build command.

I would suggest not relying on the release binaries to be statically linked. @peterbourgon thoughts?

With regards to your Dockerfile construction, I would suggest using mrnetops/fastly-exporter from docker hub or the repository Dockerfile, which explicitly build a statically linked version for the container.

Otherwise, you are attempting to rely on release build side effects.

those images are also smaller as well ;)

docker images
REPOSITORY                  TAG                 IMAGE ID            CREATED             SIZE
ljagiello/fastly-exporter   latest              96839a74ade7        17 seconds ago      16MB
mrnetops/fastly-exporter    latest              41a65eb58cdf        2 hours ago         11.3MB
alpine                      3.8                 196d12cf6ab1        2 months ago        4.41MB

Please let me know if I'm missing a nuance of your usecase / docker build.

from fastly-exporter.

ljagiello avatar ljagiello commented on May 23, 2024

Oh sure I can hack that around, it's just a different behavior between versions.

from fastly-exporter.

ljagiello avatar ljagiello commented on May 23, 2024

PR: #23

from fastly-exporter.

mrnetops avatar mrnetops commented on May 23, 2024

Release updated with new release.fish binaries.

I will however still suggest you not rely on wget of release binaries to do the right thing for your containers.

from fastly-exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.