Comments (8)
👋🏻
The following PR only took a couple of minutes for me to put together: #534
from go-fastly.
👋🏻 @relvira
Thanks for raising this issue, yes we can add that field.
The in_use
query was added to the Fastly API last year, while the rest of the TLS feature set was added to go-fastly long before that. So this new API addition slipped through the net as far as the go-fastly API client is concerned.
cc @kpfleming
from go-fastly.
Thank you for the quick response here @Integralist 🙇🏼 I definitely appreciate your interest in implementing this feature into go-fastly.
Would you have an estimate (days, weeks, months) in mind to have the feature implemented into the library? This will help us manage expectations on our side. 🙌🏼
from go-fastly.
Unfortunately we do not yet have an estimate; if we did, we'd probably be restricted from communicating it in a public place anyway :-) Please open a support ticket in Zendesk referring to this GitHub issue so that we can track the 'Fastly customer' aspects of the issue there. Thanks!
from go-fastly.
FYI it looks like it's already implemented in...
- https://pkg.go.dev/github.com/fastly/go-fastly/[email protected]/fastly#ListTLSDomainsInput
- https://pkg.go.dev/github.com/fastly/go-fastly/[email protected]/fastly#ListPrivateKeysInput
It's only missing from https://pkg.go.dev/github.com/fastly/go-fastly/[email protected]/fastly#ListCustomTLSCertificatesInput
from go-fastly.
Thank you for putting up that PR @Integralist 🙇🏼 - do you have a set cadence for creating releases in go-fastly? or is that ad-hoc?
from go-fastly.
No problem @relvira
Yeah, the release cycle currently is very much ad-hoc, but will eventually move to a more consistent/structured release cycle soon.
@kpfleming would you be OK publishing a new release? Looking at the commit history there is only this recent change and one other change that would be included in the next release (I'm not aware of any other work upcoming that we'd want to wait for).
from go-fastly.
I'll give it a try!
from go-fastly.
Related Issues (20)
- Any plan to add custom TLS certificates? HOT 1
- ListPrivateKeys: "offset must be an integer" error when requesting PageNumber 0 HOT 1
- Remove uninitialized ActiveVersion field from Service struct? HOT 3
- Potentially misleading comment in README.md HOT 2
- Purge with Soft=true bug HOT 2
- Typo in Datacenter.Coordinates - Longtitude HOT 2
- Support S3 logging `acl`, new `redundancy` options HOT 2
- GetService returns a Service with null version HOT 5
- Batch Upserting dictionary items HOT 1
- ListServices ignores all parameters HOT 2
- api throttling not exposed
- Typo in filter[tls_certificate.id] should be filter[tls_certificates.id]
- HTTP client never closes response body HOT 1
- UpdateBackend() can't clear OverrideHost and other fields? HOT 2
- Lack of support for warnings in TLSAuthorizations struct
- Allow `Context` to be set in `http.Request` for Fastly API calls HOT 3
- handle automation-tokens HOT 1
- TLSActivation Struct does not support mutual_authentication key which the API returns HOT 3
- missing input validation leads to potential data exposure or unintended data manipulation HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-fastly.