Comments (4)
Yes, using Squire in an iframe was deprecated with the Squire 2.0 release to ensure compatibility with modern frontend projects and future maintainability: https://github.com/fastmail/Squire/blob/master/CHANGELOG.md#removed
from squire.
@tjwds , thanks for the quick response. I was hoping to place this in an iframe for the isolation. I realize that dompurify does a great job of blocking, but I was hoping to be absolutely sure by disabling scripts and remote data access in the iframe .
Since you dropped the iframe support, it probably was for a good reason and might stop me from going down a fools errand of trying to get the above working. So any cautionary tales would be greatly appreciated.
Also, if I were able to add back iframe support, would an MR be considered, or would that just be a waste of effort?
Thanks,
=mark
from squire.
Also, if I were able to add back iframe support, would an MR be considered
Very unlikely. We don't plan to add options to Squire, just provide a recommended way of doing things.
from squire.
Thanks for the feedback. My plan would have not involved any settings. Just that if the element it was attached to were an iframe, it would just work. The fix would involve using the ownerDocument of the iframe instead of global document.
from squire.
Related Issues (20)
- Invalid `setKeyHandler` `key` parameter type HOT 2
- Undo/ Redo does not reset the cursor position HOT 6
- Moving the editor causes a partial breakage of functionality HOT 3
- User controlled markup vs programatically generated markup HOT 1
- Regarding inline text formatting
- The purpose of the `while` loop in the `fixCursor` function is unclear
- Lists are not created automatically on Chrome Android
- Cursor position bug after link('a' element) paste in Firefox
- Missing DOMPurify import HOT 1
- willPaste event cannot be prevented HOT 2
- Region-specific key handlers HOT 2
- Redo shortcut ("Ctrl-Shift-Z") does not work
- Can not make list for Chinese characters entered via input method on safari HOT 1
- The caret displays in a wrong position on safari HOT 1
- Wrong format after pasted some plain text at the end of formatted text
- getFontInfo returns undefined for fontFamily and fontSize when they are both set on the same selection
- Html gets reformatted on Undo
- Property 'append' does not exist on type 'Node'. HOT 1
- Applying formatting to a selection with at least one formatting set won't fire `pathChange` event HOT 4
- No API function to test for alignment HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from squire.