GithubHelp home page GithubHelp logo

Comments (4)

tjwds avatar tjwds commented on August 17, 2024

Yes, using Squire in an iframe was deprecated with the Squire 2.0 release to ensure compatibility with modern frontend projects and future maintainability: https://github.com/fastmail/Squire/blob/master/CHANGELOG.md#removed

from squire.

bonafideduck avatar bonafideduck commented on August 17, 2024

@tjwds , thanks for the quick response. I was hoping to place this in an iframe for the isolation. I realize that dompurify does a great job of blocking, but I was hoping to be absolutely sure by disabling scripts and remote data access in the iframe .

Since you dropped the iframe support, it probably was for a good reason and might stop me from going down a fools errand of trying to get the above working. So any cautionary tales would be greatly appreciated.

Also, if I were able to add back iframe support, would an MR be considered, or would that just be a waste of effort?

Thanks,

=mark

from squire.

neilj avatar neilj commented on August 17, 2024

Also, if I were able to add back iframe support, would an MR be considered

Very unlikely. We don't plan to add options to Squire, just provide a recommended way of doing things.

from squire.

bonafideduck avatar bonafideduck commented on August 17, 2024

Thanks for the feedback. My plan would have not involved any settings. Just that if the element it was attached to were an iframe, it would just work. The fix would involve using the ownerDocument of the iframe instead of global document.

from squire.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.