GithubHelp home page GithubHelp logo

Comments (4)

santisoler avatar santisoler commented on June 15, 2024

I agree with this! We would need to think what to do with the extra_coords. Any thoughts?

from verde.

leouieda avatar leouieda commented on June 15, 2024

Good point! It doesn't make sense to use extra_coords and meshgrid=False together since the whole point of extra_coords is to get a meshgrid with constant values. So maybe we just return it as is (i.e. a single value)?

from verde.

santisoler avatar santisoler commented on June 15, 2024

I agree that if we want to avoid allocating large coordinate arrays it doesn't make sense to generate huge extra_coords arrays with constant values. But it doesn't make any sense either to pass a single float (or list of floats) to extra_coords and get the same ones as output. What if we just avoid the trouble by ignoring extra_coords if we pass meshgrid=False?

from verde.

leouieda avatar leouieda commented on June 15, 2024

Sounds OK to me. Probably doesn’t matter too much which way we go since using both options together is extremely unlikely (famous last words 🥲).

from verde.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.