Error in identifier/syntax prevents autocommands to be executed about vim-go

[bhcleek]

I finally have a replication path that I can use to start tracking down the root cause.

[bhcleek]

I'm only able to duplicate a problem with the folding when other.go is opened after main.go. The other settings are applied correctly. I suspect that what's going on here is a Vim bug of some sort, not a vim-go bug. Some quick testing seems to support that idea.

The folding is as expected when other.go is opened after main.go when setting foldmethod is done unconditionally (e.g. not as part of an auto command). And interestingly, executing :setlocal foldmethod=syntax folds correctly even when setting foldmethod via the autocommand didn't cause the intended effect.

As far as I can tell, this isn't really a vim-go bug, especially given how the order file opening impacts the results.

[dunric]

@bhcleek Thank you for investigating the issue, however I beg to differ this issue is of stock Vim and not of vim-go plugin. I've experimented with removing vim-go and using only the rudimentary Go support coming with plain Vim (compiler, ftplugin, indentation & syntax highlight) and the issue didn't manifest. I've altered tabstop and foldmethod FileType plugin autocommand settings and they were correctly applied.

[bhcleek]

I hear you, @dunric. What's throwing me is that the I see tabstop applied correctly in all scenarios. I've also seen foldmethod get applied correctly with vim-go when I edit other.go very quickly after opening main.go. Something is amiss, but it's hard to track down, and I'm not yet sure what's going on.

[bhcleek]

Interestingly, it appears that editing other.go again fixes the folding 🤔 I'm really not sure what to make of this. Vim-go doesn't do anything specific with regard to setting the foldmethod.

[bhcleek]

Given that expandtab seems to be being applied correctly in all cases and that vim-go does not do anything specific with foldmethod, I'm still inclined to believe that this is some kind of Vim bug. Clearly, if it is a Vim bug, it's triggered by conditions that vim-go creates. I'll continue to see if I can narrow it down, but currently I'm stumped.

[bhcleek]

Disabling diagnostics highlighting (i.e. g:go_diagnostics_level) results in the expected behavior. Diagnostic highlighting does a few things with autocmds and also sets text properties. I'm not yet sure exactly what's triggering the errant behavior in Vim, but I suspect it's something to do with setting an autocmd or text properties while Vim is also processing for folding that causes the folds to not be applied when the foldmethod is syntax.