Comments (7)
The idea was to exclude "non interesting" mount points under some distributions such as /dev, /var/lock. It seems that Ansible doesn't include them anyway, so it's not a problem to include mount points smaller than 1gb. There should still be check for at least a size of 1 byte available, otherwise ansible-cmdb will run into division by zero errors.
Btw, ansible-cmdb does not exclude mount points with less than 1 GB free space, only mount points with less than 1 GB total space
from ansible-cmdb.
Okay, maybe I misinterpreted the check on size_total and size_available.
I way already thinking about a way to optimize the display of "Disk avail" and "Disk total" because currently it just get's mixed up and you don't know to which partition what size belongs. So the numbers are quite useless. Only the bars in "Disk usage" give you a good idea about the partitions.
from ansible-cmdb.
My proposal would be to remove "Disk total" and "Disk avail" and merge them with the "Disk usage" column:
I'm still mixing up "disk used" and "disk free" here, but that's just details. :)
from ansible-cmdb.
That looks quite nice! Maybe make the font for the sizes slightly smaller so it's easier to differentiate between the mount point and the sizes?
from ansible-cmdb.
I tried my best :)
from ansible-cmdb.
We are still ignoring partitions with a total size < 1GB with that:
% if i['size_total']/1048576000 > 1:
Maybe just ditch that line?
from ansible-cmdb.
Looks great Sven. I've merged the changes.
I've also committed a change so that disks < 1GB are shown.
Thanks for your PR and feedback!
from ansible-cmdb.
Related Issues (20)
- CSV template - rendering error after custom facts added HOT 11
- RFE: Provide ability to prune some variables from host/group vars
- Is it possible to add additional & custom columns to the CSV template? HOT 2
- Comments must be stripped before calling shlex.split
- ModuleNotFoundError: No module named 'ansiblecmdb' HOT 2
- New column: public IP address HOT 1
- [html_fancy_split] Unable to sort custom column by mixed type "string"/ "num" AND how to custom template html_fancy_split HOT 9
- CSV import feature to manage inventory and host_vars easily HOT 1
- CSV export feature for easy reporting HOT 2
- kernel info to txt_table.tpl
- Ansible Tower Generated Json Output unable to generate report HOT 1
- No suitable python version found (v2.7 or higher required). Aborting HOT 4
- Template html fancy split is broken with Edge when excluding columns HOT 1
- Debian 11 can't use default template with ansible-cmdb 1.31 HOT 3
- F
- Markdown split doesn't work
- Does not get built with python-packaging 23.0
- [Question] Offline js libraries
- Using facts_cache for esx hosts is not working properly HOT 1
- Custom fact using command output HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ansible-cmdb.