GithubHelp home page GithubHelp logo

Comments (7)

fboender avatar fboender commented on June 26, 2024

The idea was to exclude "non interesting" mount points under some distributions such as /dev, /var/lock. It seems that Ansible doesn't include them anyway, so it's not a problem to include mount points smaller than 1gb. There should still be check for at least a size of 1 byte available, otherwise ansible-cmdb will run into division by zero errors.

Btw, ansible-cmdb does not exclude mount points with less than 1 GB free space, only mount points with less than 1 GB total space

from ansible-cmdb.

muffl0n avatar muffl0n commented on June 26, 2024

Okay, maybe I misinterpreted the check on size_total and size_available.

I way already thinking about a way to optimize the display of "Disk avail" and "Disk total" because currently it just get's mixed up and you don't know to which partition what size belongs. So the numbers are quite useless. Only the bars in "Disk usage" give you a good idea about the partitions.
size

from ansible-cmdb.

muffl0n avatar muffl0n commented on June 26, 2024

My proposal would be to remove "Disk total" and "Disk avail" and merge them with the "Disk usage" column:
size

I'm still mixing up "disk used" and "disk free" here, but that's just details. :)

from ansible-cmdb.

fboender avatar fboender commented on June 26, 2024

That looks quite nice! Maybe make the font for the sizes slightly smaller so it's easier to differentiate between the mount point and the sizes?

from ansible-cmdb.

muffl0n avatar muffl0n commented on June 26, 2024

I tried my best :)

size

from ansible-cmdb.

muffl0n avatar muffl0n commented on June 26, 2024

We are still ignoring partitions with a total size < 1GB with that:

    % if i['size_total']/1048576000 > 1:

Maybe just ditch that line?

from ansible-cmdb.

fboender avatar fboender commented on June 26, 2024

Looks great Sven. I've merged the changes.

I've also committed a change so that disks < 1GB are shown.

Thanks for your PR and feedback!

from ansible-cmdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.