Comments (4)
Hey Sebastian,
For make release
, the repo has to be clear of nearly everything (.pyc files, caching, generated example output, temp files, etc). A .gitignore won't help, since the package building process doesn't reference it. But if the clean
rule is fully automatic, it might delete unstaged changes, which is the last thing I'd want. An automated build / release wouldn't have those files anyway (cause it wouldn't have been touched by humans), so the git clean -i
won't raise any questions anyway.
Initially I had separate commands in the clean
section to remove .pyc files, etc, but it took a bit too much maintenance and regularly screwed up test-released I'd make.
Perhaps we could do the following:
make clean
automatically cleans only files generated by other Make rules.make release
refuses to work unless the repo is clean. This would remove the interactive aspect of the rule, but still prevent accidental deletion of unstaged changed.
from ansible-cmdb.
Your suggestions sounds good!
Maybe use git clean -n -d -x
to show what would/should be removed?
from ansible-cmdb.
Maybe use git clean -n -d -x to show what would/should be removed?
Looks good!
from ansible-cmdb.
Fixed!
make clean
now removes build / test artifacts. A new make target release_clean
has been added which checks that the git repo is clean.
from ansible-cmdb.
Related Issues (20)
- Missing link to jquery breaks default presentation HOT 4
- CSV template - rendering error after custom facts added HOT 11
- RFE: Provide ability to prune some variables from host/group vars
- Is it possible to add additional & custom columns to the CSV template? HOT 2
- Comments must be stripped before calling shlex.split
- ModuleNotFoundError: No module named 'ansiblecmdb' HOT 2
- New column: public IP address HOT 1
- [html_fancy_split] Unable to sort custom column by mixed type "string"/ "num" AND how to custom template html_fancy_split HOT 9
- CSV import feature to manage inventory and host_vars easily HOT 1
- CSV export feature for easy reporting HOT 2
- kernel info to txt_table.tpl
- Ansible Tower Generated Json Output unable to generate report HOT 1
- No suitable python version found (v2.7 or higher required). Aborting HOT 4
- Template html fancy split is broken with Edge when excluding columns HOT 1
- Debian 11 can't use default template with ansible-cmdb 1.31 HOT 3
- F
- Markdown split doesn't work
- Does not get built with python-packaging 23.0
- [Question] Offline js libraries
- Using facts_cache for esx hosts is not working properly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ansible-cmdb.