GithubHelp home page GithubHelp logo

Make clean git -i about ansible-cmdb HOT 4 CLOSED

fboender avatar fboender commented on July 24, 2024
Make clean git -i

from ansible-cmdb.

Comments (4)

fboender avatar fboender commented on July 24, 2024

Hey Sebastian,

For make release, the repo has to be clear of nearly everything (.pyc files, caching, generated example output, temp files, etc). A .gitignore won't help, since the package building process doesn't reference it. But if the clean rule is fully automatic, it might delete unstaged changes, which is the last thing I'd want. An automated build / release wouldn't have those files anyway (cause it wouldn't have been touched by humans), so the git clean -i won't raise any questions anyway.

Initially I had separate commands in the clean section to remove .pyc files, etc, but it took a bit too much maintenance and regularly screwed up test-released I'd make.

Perhaps we could do the following:

  1. make clean automatically cleans only files generated by other Make rules.
  2. make release refuses to work unless the repo is clean. This would remove the interactive aspect of the rule, but still prevent accidental deletion of unstaged changed.

from ansible-cmdb.

rndmh3ro avatar rndmh3ro commented on July 24, 2024

Your suggestions sounds good!

Maybe use git clean -n -d -x to show what would/should be removed?

from ansible-cmdb.

fboender avatar fboender commented on July 24, 2024

Maybe use git clean -n -d -x to show what would/should be removed?

Looks good!

from ansible-cmdb.

fboender avatar fboender commented on July 24, 2024

Fixed!

make clean now removes build / test artifacts. A new make target release_clean has been added which checks that the git repo is clean.

from ansible-cmdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.