Comments (4)
Here's a wikipedia article about Irish phone numbers: https://en.wikipedia.org/wiki/Telephone_numbers_in_the_Republic_of_Ireland. It looks like they have some interesting area codes. It looks like Dublin's area code is 1, and Arklow's area code is 402. In this document local numbers appear to be dialed with 01 xxx xxxx and when using e164 format, the same number would be dialed 353 1 xxx xxxx.
from phone.
I'm updating the regex, I guess something like that will work for a while:
^(353)(1|402|404|505|90|[2-9][1-9])(.{5,7})$
I'll update the master, but I'll try to finish my changes to increase performance this weekend so I can put everything in one release.
from phone.
Also what do you think about creating a test file for each country with sample phone numbers in it? For example, Ireland's tests would be in test/phone/ie_test.exs
I had thought that a while ago, I was planning to do that on this end of the year. Initially I would do that only for the countries with area code specifications(all from NANP and Brazil by now, I think I can do Ireland too, since it's a small one).
from phone.
Awesome! Thanks for your help with this. I'll go ahead and close the issue.
from phone.
Related Issues (14)
- Angola numbers
- Remove code that leads to dialyzer warnings
- Using invalid phone numbers in testing. HOT 2
- NANP new toll free code 833 HOT 1
- restructure patter matching macros to reduce compilation time HOT 3
- Updates for the Netherlands and California
- Incorrect specs for parse/2
- Does it work for mobile phones? HOT 4
- Parser :au missing for country_parser macro in file deps/phone/lib/helpers/parser.ex HOT 1
- Brazilian mobile phone numbers cannot be parsed HOT 6
- phoenix 1.3 support ? HOT 2
- Improve tests, coverage too low
- Reduce Ebert issues HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phone.