GithubHelp home page GithubHelp logo

Comments (4)

aaronrenner avatar aaronrenner commented on May 20, 2024

Here's a wikipedia article about Irish phone numbers: https://en.wikipedia.org/wiki/Telephone_numbers_in_the_Republic_of_Ireland. It looks like they have some interesting area codes. It looks like Dublin's area code is 1, and Arklow's area code is 402. In this document local numbers appear to be dialed with 01 xxx xxxx and when using e164 format, the same number would be dialed 353 1 xxx xxxx.

from phone.

fcevado avatar fcevado commented on May 20, 2024

I'm updating the regex, I guess something like that will work for a while:
^(353)(1|402|404|505|90|[2-9][1-9])(.{5,7})$
I'll update the master, but I'll try to finish my changes to increase performance this weekend so I can put everything in one release.

from phone.

fcevado avatar fcevado commented on May 20, 2024

Also what do you think about creating a test file for each country with sample phone numbers in it? For example, Ireland's tests would be in test/phone/ie_test.exs

I had thought that a while ago, I was planning to do that on this end of the year. Initially I would do that only for the countries with area code specifications(all from NANP and Brazil by now, I think I can do Ireland too, since it's a small one).

from phone.

aaronrenner avatar aaronrenner commented on May 20, 2024

Awesome! Thanks for your help with this. I'll go ahead and close the issue.

from phone.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.