Example: Include resource with a conditional comment: <div class="snippet-c

fixed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https

hopefully I think this is a satisfying soloution <a class="commit-link" data-hovercard

HTML output from ParserService is invalid when using conditional comments about dpn_glossary HOT 5 CLOSED

featdd commented on August 21, 2024

HTML output from ParserService is invalid when using conditional comments

from dpn_glossary.

Comments (5)

featdd commented on August 21, 2024

fixed in 69a54d8

from dpn_glossary.

ducrot commented on August 21, 2024

The fix is not solving the problem. Please have a look at the following images.

First image shows the regex process before the fix. As you can see,

is replaces by
<![endif]-->
which ends in invalid html.

After the fix, the regex is too greedy. Everything from
<script ...></script><![endif]-->
to

<script type="text/javascript">
    var _gaq = _gaq || [];
    _gaq.push(['_setAccount', 'UA-xxxxxxx-1']);
    _gaq.push(['_gat._anonymizeIp']);
    _gaq.push(['_trackPageview']);
    (function() {
        var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
        ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
        var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
    })();
</script>

is matching.

The result is also invalid html:

<!--[if lt IE 9]><!--DPNGLOSSARY<script src="/typo3conf/ext/myextension/Resources/Public/js/html5.js?1394455858" type="text/javascript"></script><![endif]-->
</head>
<body>

<p> SOME TEXT</p>

<script type="text/javascript">
    var _gaq = _gaq || [];
    _gaq.push(['_setAccount', 'UA-xxxxxxx-1']);
    _gaq.push(['_gat._anonymizeIp']);
    _gaq.push(['_trackPageview']);
    (function() {
        var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
        ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
        var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
    })();
</script>-->