Const Name are not generated correctly in services index.js file about generator-feathers-plus

[eddyystop]

Your issue is fixed in f+/cli v0.7.35 using generator v0.6.34.

Please confirm. Thanks.

[eddyystop]

Better make that f+/cli v0.7.36 using generator v0.6.35. :(

[eddyystop]

Thanks for catching this.

The generator's tests use names like name1 and they don't have this problem even though the file names used are like name-1.

The problem was introduced when this generator implemented feathersjs/generator-feathers PR feathersjs-ecosystem/generator-feathers#379 "Fix renaming to preserve dot notation" (feathersjs-ecosystem/generator-feathers@5621a35) with fb8cb9d

[eddyystop]

It comes down to users1 is a valid NPM repo/file name while usersNames is not. See #59

[Mr-Martinez]

Hello @eddyystop,

I have confirmed that the issue has been resolved.

To learn just a little more about how this cli works in code, which file here contains the code that adds the names onto the service from the cli?

Edit:

Aw, I see what you meant, the feathers generator imported was changed to v0.6.35, I thought that was the plus-generator version you were referring to.

[eddyystop]

Thanks for pointing out a phrase I've used so many times is ambiguouses. f+/cli v0.7.36 which uses generator v0.6.35.

The generator semver appears under the big Feathers+ sign when you run the generator. That lets you check you are using the right version.