Comments (3)
That sounds like a reasonable fix, I think I have seen this before. A pull request would be very welcome.
from feathers-knex.
Closed via #142
from feathers-knex.
This causes an error for count
if params.knex has been modified by a hook (I added withSchema
to the query).
Line 177 in 609377d
mssql:tedious req: query: select count([insureds].[id]) as [total] from [universal].[insureds] where [name] like @p0 and [name] like @p1 order by [id] asc offset @p2 rows fetch next @p3 rows only +6s
mssql conn: acquire +2ms
mssql conn: release +36ms
mssql:tedious req: query fail { RequestError: Column "universal.insureds.id" is invalid in the ORDER BY clause because it is not contained in either an aggregate function or the GROUP BY clause.
Also, if params.knex
is used, the knexify
shouldn't be run again as you're doubling up the where clauses.
Line 182 in 609377d
from feathers-knex.
Related Issues (20)
- An in-range update of @feathersjs/adapter-commons is breaking the build 🚨 HOT 2
- An in-range update of knex is breaking the build 🚨 HOT 6
- Add array-type operators HOT 1
- An in-range update of @feathersjs/adapter-commons is breaking the build 🚨 HOT 1
- Feathers Knex generating bad COUNT query when using [$in] operator with only one value (sqlite) HOT 1
- Feathers-knex, REST and PostGIS — include examples? HOT 3
- Create method with knex plugged with mssql database returns no id. Gets General Error in feathers api HOT 2
- An in-range update of knex is breaking the build 🚨 HOT 5
- Closing the database connection / cleanup ? HOT 2
- SQL Server "Cannot read property '0' of undefined" when create HOT 1
- `find` adds the `id` column automatically with no easy way to remove it HOT 1
- No release
- Authenticate Hook => Create an unwanted query parameter 'Authorization' HOT 2
- Cannot use namespace 'Knex' as a type HOT 5
- Dynamically changing the knex schema based on request
- Fix types to work with knex > 0.95
- Re-run migrations? HOT 1
- Meta fields missing (`total`, `skip`, ...) HOT 2
- Paginated results incorrect without $sort
- Search with $ilike a value into a json column type HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from feathers-knex.