GithubHelp home page GithubHelp logo

Comments (3)

daffl avatar daffl commented on May 22, 2024

That sounds like a reasonable fix, I think I have seen this before. A pull request would be very welcome.

from feathers-knex.

daffl avatar daffl commented on May 22, 2024

Closed via #142

from feathers-knex.

jerfowler avatar jerfowler commented on May 22, 2024

This causes an error for count if params.knex has been modified by a hook (I added withSchema to the query).

(params.knex || this.db(params))

 mssql:tedious req: query: select count([insureds].[id]) as [total] from [universal].[insureds] where [name] like @p0 and [name] like @p1 order by [id] asc offset @p2 rows fetch next @p3 rows only +6s
  mssql conn: acquire +2ms
  mssql conn: release +36ms
  mssql:tedious req: query fail { RequestError: Column "universal.insureds.id" is invalid in the ORDER BY clause because it is not contained in either an aggregate function or the GROUP BY clause.

Also, if params.knex is used, the knexify shouldn't be run again as you're doubling up the where clauses.

this.knexify(countQuery, query);

from feathers-knex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.