nocache.c:148: init_mutexes: Assertion `fds_lock != NULL' failed. about nocache

[Feh]

I’ll take silence as assent and merge these two commits.

[Feh]

I see three options:

1. Change the data structure of locks to some map-like container or a search tree, using the fd as a key. This scales well for a low number of FDs, but has the same (or worse) problems when you actually want to use a billion FDs. The drawback is that you need to allocate heap memory during every system call interception.
2. Introduce an artificial cap on max_fds – make nocache work on the first N FDs, where we could pick N to be a million or 100k. That makes the fix trivial. We can implement a flag for this if people care.
3. Do nothing because this is a pathological case.

Given that it caused build failures for some people, 3) is not a real option I think. Option 2) is easy to implement correctly.

Thoughts?

[shadjiiski]

@Feh, sorry for digging in old issues. Looking in the getrlimit documentation, I believe the off-by-one issue mentioned in your commit message was introduced (instead of fixed). Left a comment for you to review in the code: ce5c187#r39007823