Double notification sound on SMS arrival.. about smsdroid

[felixb]

You need to disable the notifications in the default sms app.

[Cactus-World]

Sorry to say that, but this was already the fact and does not solve the issue. Btw, under Lollipop you can only have one default messaging application and this is set to SMSDroid.

[Cactus-World]

I just looked at the code and noticed that my suspicion in the first place seems to be the right one...

[Cactus-World]

Hi Felix,
I just created a patch that should solve this issue. Maybe you want to give it a try - at least for me it seems to work ;-).
Best,
Carsten

SingleNotificationSound.zip

[felixb]

please send the patch as pull request. it's much easier to review.
I just got a newborn. So I'm quite out of spare time right now. ;)

[Cactus-World]

Hi,
congrats! ;-) Hope she/he is allright. Well, yes, I'll try to figure out how to do that (just recently switched to GIT from CVS/Subversion and I am still learning...) Nevertheless it's just two things patched in SmsReceiver.java and MmsReceiver.java - not more than 10 lines over all...
CU,
Carsten

[felixb]

Any news on submitting a PR?

[Cactus-World]

Hallo Felix,
sorry, hier ist Land unter seit geraumer Zeit. Ich habe den Patch noch verbessert und setze dann erst den PR-jetzt bin ich aber erstmal 3 Wochen weg.
Viele Grüße,
Carsten

Am 12. Januar 2016 13:31:59 MEZ, schrieb Felix Bechstein [email protected]:

Any news on submitting a PR?

---

Reply to this email directly or view it on GitHub:
#21 (comment)

---

          Cactus World

    Multimedia & IT 
Komponenten & -dienstleistungen

    Kakteenprodukte

Im Litzelholz 94, D-54293 Trier

            Inhaber:
  Dipl.-Inform. Carsten Tichy

---

[felixb]

please check out this build/branch

http://ub0r.de/files/43038ff88f1ba31ecbed31701cdddeabff291af4-SMSdroid-release.apk

[Cactus-World]

Oh, darn, finally just figured out how to and sent the pull request with my changes and did not notice you already created another branch...

[felixb]

please verify the new version of the fix in #29.
i'll close this issue. please comment on #29 directly.

[rphair]

I have commented on issue #29 with my experience that this is still an open bug (visible for me on Nexus 5 with CM13). At least a currently valid APK file with that commit should be posted here so we can test the code if necessary & the fix referred to in #29 can be made available to the public ASAP. Sorry to be a nag but I love this app in every other way and would like to refer it to others.

[rphair]

apologies; that was pull request #29 rather than "issue" & the recently posted APK there fixes the problem.