GithubHelp home page GithubHelp logo

Comments (4)

felixhahnweilheim avatar felixhahnweilheim commented on June 9, 2024

Actually I named the file temporary.less because it is removed after the CSS has been built. (It is a workaround for the css-color-extractor to re-add the CSS variables.)

I don't really understand why the browser is showing a file that does not exist anymore (and is not mentioned in the HTML). Probably it takes the information from the last CSS line mentioning the CSS map.

So do you think we should rename the temporary file to dark-mode.less ?

from humhub-dark-mode.

marc-farre avatar marc-farre commented on June 9, 2024

The info is in theme.css.map which is created with this command:

lessc less/build2.less css/theme.css --clean-css="--s1 --advanced" --source-map=css/theme.css.map

Yes, I suggest to rename it to dark-mode.less

from humhub-dark-mode.

felixhahnweilheim avatar felixhahnweilheim commented on June 9, 2024

@marc-farre What do you think about removing the CSS map?
So the browser would just show theme.css or dark.css.

In the case of the dark themes the CSS is not usefull because the temporary.less file is actually already a compiled CSS file.

from humhub-dark-mode.

marc-farre avatar marc-farre commented on June 9, 2024

Yes, good idea.

from humhub-dark-mode.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.