GithubHelp home page GithubHelp logo

Comments (13)

FelixKratz avatar FelixKratz commented on May 29, 2024

Probably because it is not properly contained in the event payload for the space_windows_change event, you can check what is sent through this event when inserting echo "$INFO" here:


And then running sketchybar from the commandline. See if whatsapp is contained in the apps key for the space where it is opened.

from dotfiles.

timchr42 avatar timchr42 commented on May 29, 2024
Screenshot 2024-01-21 at 12 43 52

This is the output I get when running sketchy bar from command line after inserting echo "$INFO$".
Kind of confused cause this does not seem faulty right?

from dotfiles.

FelixKratz avatar FelixKratz commented on May 29, 2024

That looks good so far, try inserting echo "$app" above this line:

icon_strip+=" $($CONFIG_DIR/plugins/icon_map.sh "$app")"

from dotfiles.

timchr42 avatar timchr42 commented on May 29, 2024
Screenshot 2024-01-21 at 14 20 32

Also seems fine I guess.

from dotfiles.

FelixKratz avatar FelixKratz commented on May 29, 2024

So the problem must be in the icon_map file, you could try to copy and paste the output from this command 1:1 into to icon_map file as the key to the whatsapp icon, maybe it is because of some unicode shenanigans.

from dotfiles.

timchr42 avatar timchr42 commented on May 29, 2024

Too bad, that does also not seem to cause the problem. Pasted the output 1:1.

from dotfiles.

FelixKratz avatar FelixKratz commented on May 29, 2024

This is wild, will try to look into it because I am also a bit puzzled :D

from dotfiles.

timchr42 avatar timchr42 commented on May 29, 2024

Yeah, really weird. Bet its something stupid :D
Tanks a lot for looking into it 🙏

from dotfiles.

FelixKratz avatar FelixKratz commented on May 29, 2024

Ok so it turns out that whatsapp includes the byte sequence e2 80 8e as the leading bytes in their app name, this is the unicode character U+200E and is an invisible control character that indicates that this word shall be printed left to right in all languages, even if they are right to left.... the fix is to include this invisible control character in the icon map.

from dotfiles.

FelixKratz avatar FelixKratz commented on May 29, 2024

You need to update the font, because it contains new icons for the terminals:

curl -L https://github.com/kvndrsslr/sketchybar-app-font/releases/download/v1.0.23/sketchybar-app-font.ttf -o $HOME/Library/Fonts/sketchybar-app-font.ttf

from dotfiles.

timchr42 avatar timchr42 commented on May 29, 2024

that's what I've realised also xD
But there's still a problem. I guess the key is wrong because in icon_map.sh it says "iTerm" and not "iTerm2".

from dotfiles.

FelixKratz avatar FelixKratz commented on May 29, 2024

Oh that might be a regression introduced here:
kvndrsslr/sketchybar-app-font#38
You could report that there so it geta fixed upstream as well

from dotfiles.

timchr42 avatar timchr42 commented on May 29, 2024

yup, just did

from dotfiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.