GithubHelp home page GithubHelp logo

Consistent CI Tests about lua-resty-acme HOT 5 CLOSED

fffonion avatar fffonion commented on May 19, 2024
Consistent CI Tests

from lua-resty-acme.

Comments (5)

UXabre avatar UXabre commented on May 19, 2024

I also noticed the ci test issues and had a hard time getting something to work, in the end i singled out my test and at least I can sleep...
I'm new on the acme service side of life, but from your proposals I think pebble looks promising.
Perhaps a "smoke test" hybrid can be made in which ngrok is simply used to verify compatibility and all other tests could use pebble?
Just my 2 cents :-)

from lua-resty-acme.

fffonion avatar fffonion commented on May 19, 2024

I agree moving to use pebble is the right way to go. I intially choose frp to avoid a lock-in with ngrok,
which doesn't have a clear status of how long its free services will last.

But on the other hand either ngrok or frp should not make the test itself flakky, so the failing tests may indicates
some bugs in code, but I haven't been able to figure out yet.

from lua-resty-acme.

UXabre avatar UXabre commented on May 19, 2024

Is there any guide on setting up FRP together with this? Otherwise I'm willing to try and help figure out why some tests are flaky?

from lua-resty-acme.

fffonion avatar fffonion commented on May 19, 2024

@UXabre Yes I can share the example used in current CI. You will need a server that's accessible on public internet.
On server side, the config is:

[common]
bind_port = 7000
vhost_http_port = 80
authentication_method = token
token = <token>
subdomain_host = test.mydomain.com

Then you will have *.test.mydomain.com resolve to your server's IP. Most DNS provider allows you
to do wildcard resolving I think.

When running test suite, pass envrionment variable to it:

FRP_SERVER_HOST=<ip_of_your_server> FRP_SERVER_PORT=7000 FRP_TOKEN=<token> DOMAIN=<subdomain> t/prepare_travis.sh

prepare_travis.sh will prepare all client side environment and frpc configs and choose a random subdomain.

But on the other side, I doubt that the flaky-ness is caused by frp (right now you can't run frp-based test
suite in a PR since github doesn't expose secrets to it, but that's a different story). That means, if there's
a transient bug in code, we should be able to reproduce with ngrok as well.

from lua-resty-acme.

fffonion avatar fffonion commented on May 19, 2024

Closing this as tests have been moved to pebble.

from lua-resty-acme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.